-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move widgets from Q(Double)SpinBox to Qgs(Double)SpinBox #39075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add ${CMAKE_SOURCE_DIR}/src/gui/editorwidgets
to
QGIS/src/providers/grass/CMakeLists.txt
Line 13 in 1f7b710
${CMAKE_SOURCE_DIR}/src/gui |
Lovely work! |
The only remaining QSpinBox widgets are available in src/auth/oauth2/qgsauthoauth2edit.ui and src/ui/qgsarcgisvectortileconnectiondialog.ui. No idea where to include the widget to avoid build fail. |
@DelazJ I don't think it's possible to address the auth ones without a considerable (tricky) reworking of the auth providers. |
@DelazJ one consequence of this change is that many spin boxes are now showing clear buttons even when set to their initial default values. It's painful, but we should do a sweep of the buttons changed here and ensure that their clear value is correctly set to a reasonable default value... |
Ok. I Will take a look... |
based on #38948 (comment). Anything else to do?
Couldn't find how to make some plugins and providers dialogs use it.