Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move widgets from Q(Double)SpinBox to Qgs(Double)SpinBox #39075

Merged
merged 5 commits into from
Oct 3, 2020

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Sep 29, 2020

based on #38948 (comment). Anything else to do?

Couldn't find how to make some plugins and providers dialogs use it.

@github-actions github-actions bot added this to the 3.16.0 milestone Sep 29, 2020
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add ${CMAKE_SOURCE_DIR}/src/gui/editorwidgets to

${CMAKE_SOURCE_DIR}/src/gui
to fix the mac build failure

@nyalldawson
Copy link
Collaborator

Lovely work!

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 3, 2020

The only remaining QSpinBox widgets are available in src/auth/oauth2/qgsauthoauth2edit.ui and src/ui/qgsarcgisvectortileconnectiondialog.ui. No idea where to include the widget to avoid build fail.

@nyalldawson
Copy link
Collaborator

@DelazJ I don't think it's possible to address the auth ones without a considerable (tricky) reworking of the auth providers.

@nyalldawson nyalldawson merged commit 3b811bd into qgis:master Oct 3, 2020
@DelazJ DelazJ deleted the spinboxes branch October 4, 2020 05:00
@nyalldawson
Copy link
Collaborator

@DelazJ one consequence of this change is that many spin boxes are now showing clear buttons even when set to their initial default values. It's painful, but we should do a sweep of the buttons changed here and ensure that their clear value is correctly set to a reasonable default value...

@DelazJ
Copy link
Contributor Author

DelazJ commented Oct 5, 2020

Ok. I Will take a look...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants