Remove async from sparse_embedding_model_name property
#581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* [x] Contributions should target the `dev` branch. Did you create your branch from `dev`?
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change?
Prevents:
```
ValueError: Unsupported embedding model: <coroutine object AsyncQdrantFastembedMixin.sparse_embedding_model_name at 0x7f7f0e863d00>. Supported models: {'prithvida/Splade_PP_en_v1': {'model': 'prithvida/Splade_PP_en_v1', 'vocab_size': 30522, 'description': 'Misspelled version of the model. Retained for backward compatibility. Independent Implementation of SPLADE++ Model for English', 'size_in_GB': 0.532, 'sources': {'hf': 'Qdrant/SPLADE_PP_en_v1'}}, 'prithivida/Splade_PP_en_v1': {'model': 'prithivida/Splade_PP_en_v1', 'vocab_size': 30522, 'description': 'Independent Implementation of SPLADE++ Model for English', 'size_in_GB': 0.532, 'sources': {'hf': 'Qdrant/SPLADE_PP_en_v1'}}}
```
|
Hey @yasyf |
joein
approved these changes
Apr 5, 2024
skvark
pushed a commit
to skvark/qdrant-client
that referenced
this pull request
Apr 8, 2024
* Remove async from sparse_embedding_model_name property Co-authored-by: George Panchuk <george.panchuk@qdrant.tech>
joein
added a commit
that referenced
this pull request
Apr 22, 2024
* Remove async from sparse_embedding_model_name property Co-authored-by: George Panchuk <george.panchuk@qdrant.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove async from sparse_embedding_model_name property
devbranch. Did you create your branch fromdev?Prevents: