Skip to content

Commit

Permalink
Remove async from sparse_embedding_model_name property
Browse files Browse the repository at this point in the history
* [x] Contributions should target the `dev` branch. Did you create your branch from `dev`?
* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../../pulls) for the same update/change?

Prevents:

```
ValueError: Unsupported embedding model: <coroutine object AsyncQdrantFastembedMixin.sparse_embedding_model_name at 0x7f7f0e863d00>. Supported models: {'prithvida/Splade_PP_en_v1': {'model': 'prithvida/Splade_PP_en_v1', 'vocab_size': 30522, 'description': 'Misspelled version of the model. Retained for backward compatibility. Independent Implementation of SPLADE++ Model for English', 'size_in_GB': 0.532, 'sources': {'hf': 'Qdrant/SPLADE_PP_en_v1'}}, 'prithivida/Splade_PP_en_v1': {'model': 'prithivida/Splade_PP_en_v1', 'vocab_size': 30522, 'description': 'Independent Implementation of SPLADE++ Model for English', 'size_in_GB': 0.532, 'sources': {'hf': 'Qdrant/SPLADE_PP_en_v1'}}}
```
  • Loading branch information
yasyf committed Apr 5, 2024
1 parent c8aa21c commit 8d01b96
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qdrant_client/async_qdrant_fastembed.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def embedding_model_name(self) -> str:
return self._embedding_model_name

@property
async def sparse_embedding_model_name(self) -> Optional[str]:
def sparse_embedding_model_name(self) -> Optional[str]:
return self._sparse_embedding_model_name

def set_model(
Expand Down

0 comments on commit 8d01b96

Please sign in to comment.