Fix "Wheel naming is not following PEP 491 convention" #4766
Conversation
|
Thank you! The failing test seems to be happening now regardless of this change: https://github.com/pypa/setuptools/actions/runs/12298183072/job/34321035714#step:3:49. I don't know if anything changed in the latest versions of Python being distributed to macOS, so that |
|
Aha, that's a different failure actually, |
abravalheri
force-pushed
the
fix/3777
branch
from
92d42d1 to
c1bf7c7
Compare
This looks like it is checking deprecated functionality? Not sure we have to account such an edge case since we are moving away from |
|
I'm not sure! I think the test is just broken in a way I haven't been able to figure out (it mixes the distribution name and the namespace name as one thing in the helper functions) but I think the underlying functionality probably still works? |
|
All tests are passing, this is now ready for review. |
|
This is ready for re-review. |
|
@abravalheri @jaraco Would it be possible to get a release out with this change? This is blocking pypi/warehouse#17378 and pypi/warehouse#17377. Happy to prep/propose the release if that would help! |
|
Ok, let's get this out before we merge more stuff so that is easier to track breaking changes if any (or gauge any push back from the community). |
|
@di, sorry for the delay and thank you for working on this. CI is running for the release https://github.com/pypa/setuptools/tree/refs/tags/v75.8.1. If we want to be in the safe side, it might make sense to wait some days before to check if we have any pushbacks or bugs reported by the community. |
|
But, we had some unexplained CI errors: https://github.com/pypa/setuptools/actions/runs/13523090359/job/37786779855. I will try to re-run the failed jobs shortly. |
|
Thanks! Noted. Feel free to @ me on any related issues if they arise. |
**Context:** setuptools has had a release recently that normalizes package names: References: - pypa/setuptools#4766 - https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization **Description of the Change:** Due setuptools 75.8.0 and 75.8.1 outputting completely different package names, we cannot support both, so CI now "pins" to >=75.8.1. **Benefits:** Fix CI failures. **Possible Drawbacks:** We may need to update docs. This is also another situation where moving away from setup.py to pyproject would yield benefits. As then you can specify the minimum setuptools version as part of the build-backend configuration. **Related GitHub Issues:** None. [sc-85195](https://app.shortcut.com/xanaduai/story/85195/investigate-issue-with-pennylane-ci-failing-with-uv-build-outputting-package-that-doesn-t-match-name-in-setup-py)
Summary of changes
Fixes #3777.
Marking this as draft as there is one outstanding failing test that I have been unable to resolve (setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg).Pull Request Checklist
newsfragments/.(See documentation for details)