-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wheel naming in Docker builds for setuptools 75.8.1 compatibility #1075
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1075 +/- ##
===========================================
- Coverage 97.99% 64.15% -33.84%
===========================================
Files 233 28 -205
Lines 40019 2631 -37388
===========================================
- Hits 39215 1688 -37527
- Misses 804 943 +139 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Alex-Preciado! 😎 Happy to merge after testing the support 13597100478 and 13597101518
Could you also add your name and the title of this PR to .github/CHANGELOG.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Alex-Preciado ! Looks like the compat docker tests have passed, happy to approve!
Context:
This pull request addresses an issue with the Docker build process caused by the setuptools 75.8.1 release, which enforces stricter PEP naming conventions. For additional context you can take a look at pypa/setuptools#4766, (and the corresponding issue: pypa/setuptools#3777) in the setup tools repo.
Description of the Change:
This PR implements the following changes:
setuptools>=75.8.1
in the Docker build environment to ensure consistent and compliant wheel filename generation.pip install
command to use the correct wheel filename pattern (pennylane_lightning*.whl
).Similar changes have been applied to PennyLane in PennyLaneAI/pennylane#7005 and PennyLaneAI/pennylane#7006
Benefits:
docker-stable and docker-latest in our plugin-test-matrix should stop failing.
Related Shortcut Stories:
[sc-85485]