Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel naming in Docker builds for setuptools 75.8.1 compatibility #1075

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

Alex-Preciado
Copy link
Contributor

@Alex-Preciado Alex-Preciado commented Feb 28, 2025

Context:
This pull request addresses an issue with the Docker build process caused by the setuptools 75.8.1 release, which enforces stricter PEP naming conventions. For additional context you can take a look at pypa/setuptools#4766, (and the corresponding issue: pypa/setuptools#3777) in the setup tools repo.

Description of the Change:
This PR implements the following changes:

  • Specifies setuptools>=75.8.1 in the Docker build environment to ensure consistent and compliant wheel filename generation.
  • Updates the pip install command to use the correct wheel filename pattern (pennylane_lightning*.whl).

Similar changes have been applied to PennyLane in PennyLaneAI/pennylane#7005 and PennyLaneAI/pennylane#7006

Benefits:
docker-stable and docker-latest in our plugin-test-matrix should stop failing.

Related Shortcut Stories:
[sc-85485]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.15%. Comparing base (98a9292) to head (e35cf58).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (98a9292) and HEAD (e35cf58). Click for more details.

HEAD has 93 uploads less than BASE
Flag BASE (98a9292) HEAD (e35cf58)
99 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1075       +/-   ##
===========================================
- Coverage   97.99%   64.15%   -33.84%     
===========================================
  Files         233       28      -205     
  Lines       40019     2631    -37388     
===========================================
- Hits        39215     1688    -37527     
- Misses        804      943      +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Alex-Preciado! 😎 Happy to merge after testing the support 13597100478 and 13597101518

Could you also add your name and the title of this PR to .github/CHANGELOG.md?

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve! 🥳

Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Alex-Preciado ! Looks like the compat docker tests have passed, happy to approve!

@Alex-Preciado Alex-Preciado merged commit a655559 into master Mar 3, 2025
79 of 80 checks passed
@Alex-Preciado Alex-Preciado deleted the fix-docker-wheel-naming branch March 3, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants