refactor wheel builder to use workflows and download/build separately #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Aug 16, 2020
alex
reviewed
Aug 16, 2020
| - {VERSION: "3.6", MSVC_VERSION: "2019"} | ||
| - {VERSION: "3.7", MSVC_VERSION: "2019"} | ||
| - {VERSION: "3.8", MSVC_VERSION: "2019"} | ||
| - {VERSION: "3.8", MSVC_VERSION: "2019", "USE_ABI3": "true", "ABI_VERSION": "cp36"} |
There was a problem hiding this comment.
I win the fight on bcrypt but lose it here?
There was a problem hiding this comment.
You lose it here for now. I don't want to have our wheel infra only capable of building the new style when we don't know the results of that experiment. If bcrypt goes well we can update this before 3.1 release.
There was a problem hiding this comment.
I have confidence in the bcrypt expirement, so I guess I'm ok waiting a month to delete it :-)
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
alex
approved these changes
Aug 16, 2020
|
This fixes #4907 |
Merged
|
Build succeeded (check pipeline).
|
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one retains the abi3/non-abi3 windows hack just in case we release before our bcrypt experiment has conclusive results.