Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pep517 hack in wheel builder #4907

Closed
alex opened this issue May 31, 2019 · 5 comments
Closed

Remove pep517 hack in wheel builder #4907

alex opened this issue May 31, 2019 · 5 comments
Labels
administrative
Milestone
Thirty first release

Comments

@alex
Copy link
Member

alex commented May 31, 2019

No description provided.

@reaperhulk reaperhulk changed the title Remove pep517 hack in wheeel builder Remove pep517 hack in wheel builder Jun 1, 2019
reaperhulk referenced this issue Jun 1, 2019
@pganssle @reaperhulk
Add PEP 517 to pyproject.toml (#4783)
0d30f5d 
This puts a new minimum on the PEP 518 requirement for `setuptools`
because older versions of setuptools' PEP 517 backend will fail to
include `setup.py` in an sdist.
@alex alex added this to the Thirtieth release milestone Jul 5, 2020
@alex
Copy link
Member Author

alex commented Jul 5, 2020

@reaperhulk do you have any idea what was being requested here, and if so have we fixed it, or failing that what it's blocked on?

Putting in this milestone with the intended scope of, "Figure out what the hell this ticket was for"

@reaperhulk
Copy link
Member

I think this is the "downgrade to pip10" thing we do to avoid...I don't remember what. Something that broke us due to having a pyproject.toml. Probably the experiment to run is remove that downgrade and see if we can still build wheels?

@alex
Copy link
Member Author

alex commented Jul 12, 2020

Tried this in #5306.

ERROR: Cannot build wheel for cryptography using PEP 517 when --build-option is present

I could have sworn there was a pip bug filed for this, but I can't find it.

@alex alex removed this from the Thirtieth release milestone Jul 12, 2020
@alex
Copy link
Member Author

alex commented Jul 12, 2020

removing from the milestone since this seems to be a pip issue

@reaperhulk reaperhulk added this to the Thirty first release milestone Aug 15, 2020
@reaperhulk reaperhulk mentioned this issue Aug 16, 2020
Merged
@reaperhulk
Copy link
Member

Done

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
administrative
Milestone
Thirty first release
Development

No branches or pull requests
2 participants
@alex @reaperhulk