-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEP 517 to pyproject.toml #4783
Conversation
So without this patch if setuptools happens to be older than 40.6 when creating an sdist via It looks like the comment in |
No, this is a bug with the PEP 517 build backend, so it will fail with It's probably a pretty rare use case to build an sdist from source, but better safe than sorry. |
Okay, got it. Could you update the comment about keeping the setup_requirements and this in sync that notes why setuptools versioning doesn't match? Other than that this LGTM. |
b9bf9b3
to
5bf2db8
Compare
This puts a new minimum on the PEP 518 requirement for `setuptools` because older versions of setuptools' PEP 517 backend will fail to include `setup.py` in an sdist.
5bf2db8
to
e16d93d
Compare
@reaperhulk Updated, let me know if the comments need further changes. |
Cryptography 2.6 has a pip related bug which can break installations: pyca/cryptography#4783 Will revert this once fixed. Signed-off-by: Michael Scott <mike@foundries.io>
Cryptography 2.6 has a pip related bug which can break installations: pyca/cryptography#4783 Will revert this once fixed. Signed-off-by: Michael Scott <mike@foundries.io>
For reference this PR was unrelated to the bug in cryptography 2.6 (which was an issue with wheel building resolved by re-releasing as 2.6.1 after correcting our wheel builder scripts) |
This puts a new minimum on the PEP 518 requirement for
setuptools
because older versions of setuptools' PEP 517 backend will fail to includesetup.py
in an sdist.I will note that the presence of
pyproject.toml
alone is enough to trigger PEP 517 in the latest version ofpip
, using the default backend, so regardless of whether or notbuild-backend
is added topyproject.toml
, the bounds onsetuptools
need to be bumped (inpyproject.toml
only).