Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7109 by adding the text to body in contact moderators "mailto:… #7128

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Fixes #7109 by adding the text to body in contact moderators "mailto:… #7128

merged 2 commits into from
Jan 7, 2020

Conversation

sunguru98
Copy link
Contributor

@sunguru98 sunguru98 commented Jan 7, 2020

…" Link

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #7128 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7128      +/-   ##
==========================================
+ Coverage   80.81%   80.83%   +0.02%     
==========================================
  Files          97       97              
  Lines        5568     5574       +6     
==========================================
+ Hits         4500     4506       +6     
  Misses       1068     1068
Impacted Files Coverage Δ
app/controllers/application_controller.rb 92.37% <0%> (ø) ⬆️
app/controllers/editor_controller.rb 74.41% <0%> (+1.44%) ⬆️
app/models/drupal_content_field_mapper.rb 100% <0%> (ø) ⬆️
app/channels/application_cable/connection.rb 100% <0%> (ø) ⬆️
app/controllers/talk_controller.rb 100% <0%> (ø) ⬆️
app/channels/application_cable/channel.rb 100% <0%> (ø) ⬆️
app/mailers/password_reset_mailer.rb 100% <0%> (ø) ⬆️
app/models/drupal_content_field_map_editor.rb 100% <0%> (ø) ⬆️
app/controllers/home_controller.rb 98.38% <0%> (ø) ⬆️
app/controllers/search_controller.rb 97.67% <0%> (ø) ⬆️
... and 51 more

@sunguru98
Copy link
Contributor Author

For some reason, I couldnt merge it, could some one help me please?

@sunguru98
Copy link
Contributor Author

Done after looking at the Travis CI documentation. I had to change the test as well.

@skilfullycurled
Copy link
Contributor

Hey @sunguru98, only some members of the group have the ability to merge after they review your tests and code. When you are ready to have someone take a look, ping the reviewers by using the following @publiclab/reviewers, which I'll do right now. : )

Hi @publiclab/reviewers, can someone please take a look at this pull request when you have a chance? It's an FTO so I'd love to provide the satisfaction of finishing one as soon as you are able to!

@skilfullycurled
Copy link
Contributor

Oh also, @sunguru98, don't forget to add the number of the issue this is a fix for at the top:

Fixes #0000 (<=== Add issue number here)

@jywarren
Copy link
Member

jywarren commented Jan 7, 2020

Looks awesome! Thanks so much!!

@jywarren jywarren merged commit 1539c53 into publiclab:master Jan 7, 2020
@welcome
Copy link

welcome bot commented Jan 7, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

jywarren commented Jan 7, 2020

Fixed #7109 ! Thanks everyone!!!! Great work! 🎉

@sunguru98 sunguru98 changed the title #7109 fixed by adding the text to body in contact moderators "mailto:… Fixes #7109 by adding the text to body in contact moderators "mailto:… Jan 7, 2020
@sunguru98
Copy link
Contributor Author

Oh my God Oh my God Oh my God ... Im literally in cloud nine

@sunguru98 sunguru98 deleted the issue-7109 branch January 7, 2020 18:32
@cesswairimu
Copy link
Collaborator

Awesome job @sunguru98, Welcome to PublicLab 🎈

Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this pull request Jan 14, 2020
… "mailto:… (publiclab#7128)

* publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link

* Updated the test as well
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
… "mailto:… (publiclab#7128)

* publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link

* Updated the test as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants