-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7109 by adding the text to body in contact moderators "mailto:… #7128
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7128 +/- ##
==========================================
+ Coverage 80.81% 80.83% +0.02%
==========================================
Files 97 97
Lines 5568 5574 +6
==========================================
+ Hits 4500 4506 +6
Misses 1068 1068
|
For some reason, I couldnt merge it, could some one help me please? |
Done after looking at the Travis CI documentation. I had to change the test as well. |
Hey @sunguru98, only some members of the group have the ability to merge after they review your tests and code. When you are ready to have someone take a look, ping the reviewers by using the following @publiclab/reviewers, which I'll do right now. : ) Hi @publiclab/reviewers, can someone please take a look at this pull request when you have a chance? It's an FTO so I'd love to provide the satisfaction of finishing one as soon as you are able to! |
Oh also, @sunguru98, don't forget to add the number of the issue this is a fix for at the top:
|
Looks awesome! Thanks so much!! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Fixed #7109 ! Thanks everyone!!!! Great work! 🎉 |
Oh my God Oh my God Oh my God ... Im literally in cloud nine |
Awesome job @sunguru98, Welcome to PublicLab 🎈 |
… "mailto:… (publiclab#7128) * publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link * Updated the test as well
… "mailto:… (publiclab#7128) * publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link * Updated the test as well
…" Link
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!