Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Text To Body In Contact Moderators "mailto:" Link #7109

Closed
5 tasks
skilfullycurled opened this issue Jan 4, 2020 · 24 comments
Closed
5 tasks

Add Text To Body In Contact Moderators "mailto:" Link #7109

skilfullycurled opened this issue Jan 4, 2020 · 24 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute HTML

Comments

@skilfullycurled
Copy link
Contributor

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

This issue stems from #6962 (a related FTO!). We want to reduce the ammont of back and forth email communication when a user contacts us because they believe they have been mistakenly banned. Currently, moderators can only find a banned user via their user name. #6962 adds the ability to find them using their email address.

However, finding a banned user by email address is taxing on the server for reasons described in #6962. Therefore, in an effort to avoid having to use that, we are adding text to the mailto link to automatically populate the email with text in the body that requests the username and email address.

You can read more about the mailto link here and play around with the different parameters here.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file /app/controllers/application_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

flash[:warning] = "The user '#{@current_user.username}' has been placed in moderation; please see <a href='https://#{request.host}/wiki/moderators'>our moderation policy</a> and contact <a href='mailto:moderators@#{request.host}'>moderators@#{request.host}</a> if you believe this is in error."

Please add the following:

?body=Please make sure to include your username and the email address you used to sign up for the site.

Like so:

...and contact <a href='mailto:moderators@#{request.host}?body=Please make sure to include your username and the email address you used to sign up for the site.'>moderators@#{request.host}</a> if you believe this is in error."

The final result should look like this:

flash[:warning] = "The user '#{@current_user.username}' has been placed in moderation; please see <a href='https://#{request.host}/wiki/moderators'>our moderation policy</a> and contact <a href='mailto:moderators@#{request.host}?body=Please make sure to include your username and the email address you used to sign up for the site.'>moderators@#{request.host}</a> if you believe this is in error." 

See this page for some help in taking your first steps!

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@skilfullycurled skilfullycurled added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Jan 4, 2020
@jywarren jywarren added help wanted requires help by anyone willing to contribute HTML labels Jan 5, 2020
@sunguru98
Copy link
Contributor

sunguru98 commented Jan 5, 2020

I want to take this, please. It seems easy for me and will add experience to my OSC belt :), I don't know the etiquette even for claiming haha. I also added and keeping it ready for your approval

@skilfullycurled
Copy link
Contributor Author

Thanks @sunguru98, that was quick!

As far as claiming goes, I'd say, if you see a comment thread, then just ask if anyone already has it. If it's completely empty, I think it's safe to just claim it. No justification necessary, it's just so people don't double up.

@shipcy
Copy link
Contributor

shipcy commented Jan 6, 2020

I want to take this issue. Please let me know if I'm allowed to take this issue.

@skilfullycurled
Copy link
Contributor Author

skilfullycurled commented Jan 6, 2020 via email

@skilfullycurled
Copy link
Contributor Author

@sunguru98, now that you've completed the task, don't forget to click all of the check boxes up to. One of them will be for making a pull request, which you should do if you haven't yet done so. I think the people who approve them look for all of the boxes to be ticked off.

@skilfullycurled
Copy link
Contributor Author

@shipcy, the related one is #6962. I'm going to go fix it up right now.

@skilfullycurled
Copy link
Contributor Author

Okay @shipcy, #6962 is all set for the taking (if you want it, that is). If, for whatever reason, you're uninterested, just leave a note there so someone else knows it's claimable again.

@shipcy
Copy link
Contributor

shipcy commented Jan 6, 2020

@skilfullycurled Sir, I really don't know how to do this. If you can guide me then I'll take this issue otherwise I'll leave this issue and look for another one.
Thanks!

@skilfullycurled
Copy link
Contributor Author

No "sirs" necessary, Benjamin will be fine. ; )

We are absolutely here to guide you! The process is no different than this one. If you think you can do this one, I'm confident with some help you can do the other one, if you're interested. Let's move the conversation over to #6962, because everyone on the thread can help out. I'm going to ask you a question over there.

@shipcy
Copy link
Contributor

shipcy commented Jan 6, 2020

@skilfullycurled yeah, sure!

@skilfullycurled
Copy link
Contributor Author

Oh, as an aside @shipcy, I didn't know anything about contributing to another repo when I started, so don't worry about that! Everyone is here to help no matter your experience, and even after you complete an FTO.

@shipcy
Copy link
Contributor

shipcy commented Jan 6, 2020

@skilfullycurled Thank you so much!

@shipcy
Copy link
Contributor

shipcy commented Jan 6, 2020

@skilfullycurled and you were talking about some question above. What's the question then?

@skilfullycurled
Copy link
Contributor Author

Yes, click on this link. I moved the conversation to the issue that I'm taking about.

@sunguru98
Copy link
Contributor

I completed the solution and even tries to PR it, but it gives me some Codeclimate error, dont know what that is about. I went and changed the tests and then tried again. No use. Please help me @skilfullycurled

@skilfullycurled
Copy link
Contributor Author

skilfullycurled commented Jan 7, 2020 via email

jywarren pushed a commit that referenced this issue Jan 7, 2020
#7128)

* #7109 fixed by adding the text to body in contact moderators "mailto:" Link

* Updated the test as well
@jywarren jywarren closed this as completed Jan 7, 2020
@jywarren
Copy link
Member

jywarren commented Jan 7, 2020

🎉

@sunguru98
Copy link
Contributor

Holy mangoesss ... Did I just push in the code amongst a huge community ??????????

@jywarren
Copy link
Member

jywarren commented Jan 7, 2020

You sure did 😂 congrats! It should go live at https://stable.publiclab.org shortly, and to the production site https://publiclab.org during the coming week!

🚀 🎸 🙌

@jywarren
Copy link
Member

jywarren commented Jan 7, 2020

You are also featured now on https://code.publiclab.org/ as a contributor! ❤️

image

@sunguru98
Copy link
Contributor

I am just speech less now ... Thank you sooo much for accepting this.. It literally means the world to me.

@skilfullycurled
Copy link
Contributor Author

Great job @sunguru98, I know the feeling! We’ll have to figure out a way to

Bringing in at @ebarry and @bronwen9.

Between this and @shipcy’s work (also just merged! 🎉) the back and forth for collecting info from the person contacting the moderators will be reduced, hopefully to none!

@sunguru98, if you want to try out the feature, make an account on publiclab.org (if you haven’t already). Let me know here, and I’ll ban you so the next time you log in, you can use the feature to email the moderators we’ll unban you. : )

Sent with GitHawk

@skilfullycurled
Copy link
Contributor Author

Oh, @sunguru98, also, let me know your username after you make the account.

@sunguru98
Copy link
Contributor

Definitely. Pretty much the same name would be. @sunguru98 lol @skilfullycurled.

Tlazypanda pushed a commit to Tlazypanda/plots2 that referenced this issue Jan 14, 2020
… "mailto:… (publiclab#7128)

* publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link

* Updated the test as well
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this issue Feb 1, 2020
… "mailto:… (publiclab#7128)

* publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link

* Updated the test as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute HTML
Projects
None yet
Development

No branches or pull requests

4 participants