-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Text To Body In Contact Moderators "mailto:" Link #7109
Comments
I want to take this, please. It seems easy for me and will add experience to my OSC belt :), I don't know the etiquette even for claiming haha. I also added and keeping it ready for your approval |
Thanks @sunguru98, that was quick! As far as claiming goes, I'd say, if you see a comment thread, then just ask if anyone already has it. If it's completely empty, I think it's safe to just claim it. No justification necessary, it's just so people don't double up. |
I want to take this issue. Please let me know if I'm allowed to take this issue. |
Hi Shipra,
I think someone already completed this (responding from my phone so I can’t see the site right now).
If you look in the narrative up top, there’s a related issue. It’s slightly more complicated, but not by much. I haven’t set it up as an FTO yet, it’s still an FTO candidate. All I need to do is take all of the decisions and group them into a step by step up top.
But you can go ahead and claim it if you want, and I’ll go work on it. I can finish it the next hour, probably before. And if you add a message, you’ll be subscribed and I can let you know when it’s ready...?
If, after I finish, you decide you don’t want to do it or you find a different one, then just leave a note saying you’ll find/have found a different one.
… On Jan 6, 2020, at 6:28 AM, Shipra Choudhary ***@***.***> wrote:
I want to take this issue. Please let me know if I'm allowed to take this issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@sunguru98, now that you've completed the task, don't forget to click all of the check boxes up to. One of them will be for making a pull request, which you should do if you haven't yet done so. I think the people who approve them look for all of the boxes to be ticked off. |
@skilfullycurled Sir, I really don't know how to do this. If you can guide me then I'll take this issue otherwise I'll leave this issue and look for another one. |
No "sirs" necessary, Benjamin will be fine. ; ) We are absolutely here to guide you! The process is no different than this one. If you think you can do this one, I'm confident with some help you can do the other one, if you're interested. Let's move the conversation over to #6962, because everyone on the thread can help out. I'm going to ask you a question over there. |
@skilfullycurled yeah, sure! |
Oh, as an aside @shipcy, I didn't know anything about contributing to another repo when I started, so don't worry about that! Everyone is here to help no matter your experience, and even after you complete an FTO. |
@skilfullycurled Thank you so much! |
@skilfullycurled and you were talking about some question above. What's the question then? |
Yes, click on this link. I moved the conversation to the issue that I'm taking about. |
I completed the solution and even tries to PR it, but it gives me some Codeclimate error, dont know what that is about. I went and changed the tests and then tried again. No use. Please help me @skilfullycurled |
First, you’re going a great job figuring everything out!
My code climate didn’t (and still don’t always) pass, it’s super frustrating. This is very normal. You’re doing all the right things.
And, you’ll have a chance to learn how to debug with code climate. Like I said, this won’t be the last time you’ll be in this position.
Another benefit is that code climate tests do not fail for code that is technically correct, but doesn’t do what you want, so it forces you to look it over.
I’ll take a look as soon as I can. If we can’t figure it out, we’ll call in a few senior members, which will be good so you can get to know them.
Again, you’re doing great without a lot of help, so I hope you’re feeling good about that.
|
🎉 |
Holy mangoesss ... Did I just push in the code amongst a huge community ?????????? |
You sure did 😂 congrats! It should go live at https://stable.publiclab.org shortly, and to the production site https://publiclab.org during the coming week! 🚀 🎸 🙌 |
You are also featured now on https://code.publiclab.org/ as a contributor! ❤️ |
I am just speech less now ... Thank you sooo much for accepting this.. It literally means the world to me. |
Great job @sunguru98, I know the feeling! We’ll have to figure out a way to Bringing in at @ebarry and @bronwen9. Between this and @shipcy’s work (also just merged! 🎉) the back and forth for collecting info from the person contacting the moderators will be reduced, hopefully to none! @sunguru98, if you want to try out the feature, make an account on publiclab.org (if you haven’t already). Let me know here, and I’ll ban you so the next time you log in, you can use the feature to email the moderators we’ll unban you. : ) Sent with GitHawk |
Oh, @sunguru98, also, let me know your username after you make the account. |
Definitely. Pretty much the same name would be. @sunguru98 lol @skilfullycurled. |
… "mailto:… (publiclab#7128) * publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link * Updated the test as well
… "mailto:… (publiclab#7128) * publiclab#7109 fixed by adding the text to body in contact moderators "mailto:" Link * Updated the test as well
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
This issue stems from #6962 (a related FTO!). We want to reduce the ammont of back and forth email communication when a user contacts us because they believe they have been mistakenly banned. Currently, moderators can only find a banned user via their user name. #6962 adds the ability to find them using their email address.
However, finding a banned user by email address is taxing on the server for reasons described in #6962. Therefore, in an effort to avoid having to use that, we are adding text to the mailto link to automatically populate the email with text in the body that requests the username and email address.
You can read more about the mailto link here and play around with the different parameters here.
📋 Step by Step
🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file /app/controllers/application_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.
plots2/app/controllers/application_controller.rb
Line 88 in 964be1f
Please add the following:
?body=Please make sure to include your username and the email address you used to sign up for the site.
Like so:
...and contact <a href='mailto:moderators@#{request.host}?body=Please make sure to include your username and the email address you used to sign up for the site.'>moderators@#{request.host}</a> if you believe this is in error."
The final result should look like this:
See this page for some help in taking your first steps!
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
The text was updated successfully, but these errors were encountered: