Minor refactoring of search service #6918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6882 I have refactored some of the code from the search_service.rb file. These changes are still minor but I'd appreciate feedback or help on how I can refactor other parts of the code. I have tried refactoring the search_all method using the built-in ruby send function but although the code worked, it wasn't shorter than the existing method. I really want to improve this pull request because for now the changes are small and I'd really appreciate any guidance or pointers on how I can do this. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6882
I have refactored some of the code from the search_service.rb file. These changes are still minor but I'd appreciate feedback or help on how I can refactor other parts of the code. I have tried refactoring the
search_allmethod using the built-in ruby send function but although the code worked, it wasn't shorter than the existing method.I really want to improve this pull request because for now the changes are small and I'd really appreciate any guidance or pointers on how I can do this.
Thanks