Refactor search service code

[grvsachdeva]

Code for the search_service can be found here -
https://github.com/publiclab/plots2/blob/master/app/services/search_service.rb

What's required:

1. Refactor the methods so as to remove duplicate lines and remove redundant lines.
2. After refactorization, make sure tests are passing and you're more than welcome to write tests if they don't exist
3. Refactorizations should be up to mark for the task to be considered complete

Thanks!

[SidharthBansal]

Hello Gaurav, I have published this task.
The beginner is primarily for FTOs or similar things, so I have moved this task to medium.
In case you want beginner label then please reformat it using FTO template and ping me.
Thanks for your help Gaurav!

[Uzay-G]

Hey! I am working on this task and will claim it when my other task is accepted. For the [code] from line 58 to 75 I have refactored those methods into one. Should I find when the old methods are used and replace them with the new one on my forked repo? Thanks!

[SidharthBansal]

Hello, at a time you can claim only one task. Have you installed plots2 repo and is that task approved? Have you read the welcoming post? Thanks

…

On Wed, 4 Dec 2019, 12:58 am Uzay-G, ***@***.***> wrote: Hey! I am working on this task and will claim it when my other task is accepted. For the [code] from line 58 to 75 I have refactored those methods into one. Should I find when the old methods are used and replace them with the new one on my forked repo? Thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6882?email_source=notifications&email_token=AFAAEQYXGF6RFE4RZQ7JBO3QW2XM5A5CNFSM4JTG7DN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF2Q7KI#issuecomment-561319849>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ7ODNZ2WF4AP4D72X3QW2XM5ANCNFSM4JTG7DNQ> .

[SidharthBansal]

Please ensure the above two and solving a first timers only labelled issue before doing this issue. Thanks

[Uzay-G]

Oh yeah I'm sorry @SidharthBansal. My other task was done and got approved yesterday. I hadn't seen the plots2 installation task but I have done it and submitted it for review.

Thanks a lot! 😄

[SidharthBansal]

Have you read about the welcoming post ?

…

On Wed, 4 Dec 2019, 12:35 pm Uzay-G, ***@***.***> wrote: Oh yeah I'm sorry @SidharthBansal <https://github.com/SidharthBansal>. My other task was practically done and got approved yesterday. I hadn't seen the plots2 installation task but I had already done it and I now submitted my screenshot of the server. I've done a beginners issue but I'll also do a first-timers one before I work on this task. Thanks a lot! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6882?email_source=notifications&email_token=AFAAEQ4NXHFD6YH7IBINIIDQW5JEHA5CNFSM4JTG7DN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF362UA#issuecomment-561507664>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQZMCI756N7ECAQCDCTQW5JEHANCNFSM4JTG7DNQ> .

[keshav234156]

@Uzay-G You should first claim the task on GCI dashboard related to this issue, then you can start working on this issue. your installation tasks have been approved as well!!

[VladimirMikulic]

@Uzay-G what happened to your PRs?

[SidharthBansal]

I think he is busy somewhere. Take your time @Uzay-G

…

On Fri, Jan 31, 2020 at 8:45 PM Vladimir Mikulic ***@***.***> wrote: @Uzay-G <https://github.com/Uzay-G> what happened to yours PRs? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6882?email_source=notifications&email_token=AFAAEQ2QITWQKN7ZUGNBKEDRAQ6AXA5CNFSM4JTG7DN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKO6RIQ#issuecomment-580774050>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFAAEQ54DWJNXDLDBFFYKSTRAQ6AXANCNFSM4JTG7DNQ> .

[SidharthBansal]

@Uzay-G any progress here?

[Uzay-G]

No I am a bit stuck on this one