grid added to location form, closes #1170

[mridulnagpal]

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

• all tests pass -- rake test:all
• code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
• pull request is descriptively named with #number reference back to original issue
• if possible, multiple commits squashed if they're smaller changes
• reviewed/confirmed/tested by another contributor or maintainer
• schema.rb.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

[mridulnagpal]

https://github.com/mridulnagpal/plots2.git

[jywarren]

Oh cool! Is it possible to make the squares transparent?

Also, although it now reads better in mobile, I think it's quite a bit too big in desktop view. Perhaps vw isn't quite what we need?

[mridulnagpal]

I have now used font-size: %

[mridulnagpal]

The squares are now transparent as well

[jywarren]

Looks great, thanks -- do you think you could move the grid code into a JavaScript file, rather than it being inline? You could:

• wrap it in a function addGrid(map) { ... } method
• move the code itself to /app/assets/javascripts/locationForm.js
• include it via: <%= javascript_include_tag "locationForm" %>
• inline, just call that function with addGrid(map);

Does that makes sense? I'd have made a new issue for these steps, but I think it's fairly straightforward.

Thank you!

[mridulnagpal]

@jywarren Made the changes

[jywarren]

This looks awesome, thank you! Merging.