Major geographic feature planning issue

[jywarren]

We've had a wide variety of geographic features planned, built, attempted... this is the issue to organize them all! This is from a planning session with @ebarry and @steviepubliclab. Ask if you'd like to be involved!

Things listed here can/should be broken out into their own issues, and added to the Geography milestone: https://github.com/publiclab/plots2/milestone/7

Add location to profile

• User interface design - done-ish? by @ebarry? New template for location entry form #1035 -- in the gif on this one
• Blank template at url https://publiclab.org/locations/form so we can test it out - claimed! - New template for location entry form #1035 - completed in new template for location entry form #1044
• HTML markup of the location form - would go into template from New template for location entry form #1035, but leave map as a grey square at the top, for now - broken out into Fill out new HTML form for location entry #1107 and complete in Forms page updated #1120.
• move actual input form into a partial template for use in location entry across the site (in Fix/leaflet map display Closes #1130 #1131)
• Leaflet map display - at top of New template for location entry form #1035's blank template - use Leaflet as per examples to display a zoomable/draggable map in the form (above) -- build on this helper: helper maps, closes #1001 #1094 - code example here: <%= render_map(@node.lat, @node.lon, @maps) %> (in Fix/leaflet map display Closes #1130 #1131)
• Display a dot at the center of the map, that stays fixed at the center as you pan the map underneath/around it (see example code for this here) (fixed in marker added to center of map fixes #1148 #1149 by @mridulnagpal)
• Get an integer lat/lon grid to show up on the map: https://www.npmjs.com/package/leaflet-virtual-grid (fixed in grid added to location form, closes #1170 #1171 by @mridulnagpal)
• Shade or highlight the grid square the center dot is inside of (done in grid square shading, closes #1182 #1202 by @mridulnagpal)
• Placename autocompletion (break me up) like MapKnitter new map form, as done in this interface, which you can view at https://publiclab.org/profile/info/your_username
• zoom/pan the map as you autocomplete a textual search for a place, to center on the new location
• make gridSquareNWCorner() method which returns upper-left bound of active grid square
• Get form to submit request with lat/lon bounds
• Make dragging the map trigger reverse geocoding (turning lat/lon into a textual place name) to populate a "location" text input using this code
• offer to use the geolocation API to find where you are now
• Write controller action to receive the region box and add it to user profile
  • https://github.com/publiclab/plots2/blob/master/app/controllers/location_tags_controller.rb (already written, look into)
• add powertag: region:lat-lon - https://github.com/publiclab/plots2/blob/master/app/controllers/user_tags_controller.rb
• Redirected to your profile with message "Your location was saved"

Profile display

• Design a display for a location on a profile page (like https://publiclab.org/profile/liz)
• Choose a single, random "example location" (Publiclandia) for someone to figure out how to display
• Hide this display behind a "geo" GET parameter like https://publiclab.org/profile/liz?geo=true
• Display grid as in above leaflet-virtual-grid issue and shade the appropriate
• Display a small map to show on profile pages -- hidden behind get param (same as above) and show example location
• Connect small profile map to profile stored location

Remove location from profile

• Controller action to do this --
• use user_tag_controller
• Message: Your location was removed.
• Interface on the profile -- button with "confirm"

View people by region on a map

• Create a template at https://publiclab.org/people/map (for starters)
• Get a zoomable Leaflet map to show up there, like https://publiclab.org/archive page
• Get a grid to show up on the map: https://www.npmjs.com/package/leaflet-virtual-grid
• Redirect to URL: https://publiclab.org/region/lat/lon when you click a region
• Publish the map at https://publiclab.org/people
• Create a JSON action listing regions (lat/lon) and headcount
• Shade the grid by # of ppls in that square based on JSON format from above

---

Other projects to plan for:

• Think about how people and projects and questions and other things are listed in a common map
• Map view for tag page
• Location-based notifications
  • subscription to location notifications
  • subscriptions to additional region grid squares you're not in yourself
  • callouts to regions: @location:lat,lon -- "oh hai @region:42,-75 did you see this new permit that got filed for a sand frac mine?"
• adding location using above location input form, but to notes or wiki pages
• a map view for notes/wiki pages
• a generalizable/parametric partial template for location entry

[ebarry]

Quick reading shows that the convention might be to use the lower left coordinate pair lat,lng to indicate a grid square. Any other thoughts on this?

[jywarren]

sounds good - can you edit the issue to reflect this? THanks!

…

On Wed, Dec 7, 2016 at 10:05 AM, Liz Barry ***@***.***> wrote: Quick reading shows that the convention might be to use the lower left coordinate pair lat,lng to indicate a grid square. Any other thoughts on this? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8K0HUel4sNjAKBsU6DL_NHzKGUaks5rFss8gaJpZM4LF8ds> .

[jywarren]

Hi @mridulnagpal -- if you're interested in a new challenge, these two (from above) could become a new issue:

• move actual input form into a partial template for use in location entry across the site
• Leaflet map display - at top of New template for location entry form #1035's blank template - use Leaflet as per examples to display a zoomable/draggable map in the form (above) -- build on this helper: helper maps, closes #1001 #1094 - code example here: <%= render_map(@node.lat, @node.lon, @maps) %>

[mridulnagpal]

@jywarren Roger that 👍

[mridulnagpal]

@jywarren How do I proceed?

[jywarren]

So, first if you could use the helper method in #1094 to display a map in the provided box, then change the template to a partial template. You can look up partial templates in the rails docs but it means you can include it in another template. Make sense? Thanks!!!

[mridulnagpal]

@jywarren What would be the arguments for the helper method?

[jywarren]

Let's just start with a random example location of your choice, and an empty array of items.

…

On Dec 18, 2016 2:44 PM, "Mridul Nagpal" ***@***.***> wrote: @jywarren <https://github.com/jywarren> What would be the arguments for the helper method? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyzHiJxMNOteoJozosYsNBslHrGmks5rJY05gaJpZM4LF8ds> .

[mridulnagpal]

@jywarren It gives an error because of the empty array of objects undefined method `each' for nil:NilClass

[jywarren]

Ah, but could you pass an empty array like `[]`?

…

On Dec 18, 2016 3:24 PM, "Mridul Nagpal" ***@***.***> wrote: @jywarren <https://github.com/jywarren> It gives an error because of the empty array of objects undefined method `each' for nil:NilClass — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ4ixQ_7xQTgRNsSbbcWpMnzZdK_Pks5rJZaAgaJpZM4LF8ds> .

[mridulnagpal]

Cool, I tried it and it worked but cannot see a map on the page yet.

[jywarren]

Hmm, perhaps you could look at the js console in the browser?

…

On Dec 19, 2016 3:36 AM, "Mridul Nagpal" ***@***.***> wrote: Cool, I tried it and it worked but cannot see a map on the page yet. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ6Nkke8-kO2LUVBfuXb39iKE4IyAks5rJkIFgaJpZM4LF8ds> .

[mridulnagpal]

It says Map container not found On 20 December 2016 at 02:15, Jeffrey Warren <notifications@github.com> wrote:

…

Hmm, perhaps you could look at the js console in the browser? On Dec 19, 2016 3:36 AM, "Mridul Nagpal" ***@***.***> wrote: > Cool, I tried it and it worked but cannot see a map on the page yet. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1070 (comment) >, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABfJ6Nkke8- kO2LUVBfuXb39iKE4IyAks5rJkIFgaJpZM4LF8ds> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVULlGPG_v4v8Q9l5ICiOkRb4_cVEVPCks5rJuzlgaJpZM4LF8ds> .

[jywarren]

Ah -- does the helper template in /app/views/map/map_helper contain the div w id "map" that the helper is inserting the map into?

…

On Dec 19, 2016 4:17 PM, "Mridul Nagpal" ***@***.***> wrote: It says Map container not found On 20 December 2016 at 02:15, Jeffrey Warren ***@***.***> wrote: > Hmm, perhaps you could look at the js console in the browser? > > On Dec 19, 2016 3:36 AM, "Mridul Nagpal" ***@***.***> wrote: > > > Cool, I tried it and it worked but cannot see a map on the page yet. > > > > — > > You are receiving this because you were mentioned. > > Reply to this email directly, view it on GitHub > > <#1070# issuecomment-267909303 > >, > > or mute the thread > > <https://github.com/notifications/unsubscribe-auth/AABfJ6Nkke8- > kO2LUVBfuXb39iKE4IyAks5rJkIFgaJpZM4LF8ds> > > > . > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1070 (comment) >, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AVULlGPG_ v4v8Q9l5ICiOkRb4_cVEVPCks5rJuzlgaJpZM4LF8ds> > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJxidOfSMHnRlZN6Avs23J3zftwYHks5rJvRqgaJpZM4LF8ds> .

[mridulnagpal]

No its just the script tag in _leaflet no div tags

[jywarren]

Ah - it needs a div with the right ID -- check out how it's done in /views/sidebar/_related.html.erb, for reference. And perhaps we should move the div into the helper template, since it'll usually be needed? Or people may want to style it differently and we should keep it outside?

Let's also create a new issue for this sub-issue, so we don't clutter the comments up for this umbrella-issue, since we'll be using it for a while :-) sound good? Thanks, and apologies for the slower pace of input while I'm traveling for the next few days!

[mridulnagpal]

@jywarren I think #1130 is resolved in #1131. Please review.

[jywarren]

Yes -- thanks! If you'd like to tackle the next two here, they have to do with Leaflet JavaScript work.

[mridulnagpal]

@jywarren Yeah sure

[jywarren]

https://publiclab.org/locations/form

[jywarren]

Great work, @mridulnagpal -- maybe this new next step?

make gridSquareNWCorner() method which returns upper-left bound of active grid square

[jywarren]

Hi, it looks all right, but the shaded grid square is not refreshing. I see a delayFactor parameter in the code -- do you know what's going on, @mridulnagpal ?

https://publiclab.org/locations/form

[mridulnagpal]

@jywarren delayFactor decides how much interval is there in rendering different cells, for example if delayFactor is high all the cells come after some interval one after the other, we can set it to 0 if we want alll the cells to render at the same time.

[jywarren]

Ah, interesting. Well, I think it's only shading on the initial draw, and we need it to refresh the active cell as the map moves. Do you think that's a next step you could attempt? Thanks for your hard work!

…

On Thu, Jan 26, 2017 at 11:43 PM, Mridul Nagpal ***@***.***> wrote: @jywarren <https://github.com/jywarren> delayFactor decides how much interval is there in rendering different cells, for example if delayFactor is high all the cells come after some interval one after the other, we can set it to 0 if we want alll the cells to render at the same time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1070 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ295w8C-iMNeP9R5SX8sjwMzGuAhks5rWXX4gaJpZM4LF8ds> .

[mridulnagpal]

@jywarren I have made another PR for it. It works fine now.

[mridulnagpal]

@jywarren how do we start on the next one?

[jywarren]

Placename autocompletion (break me up) like MapKnitter new map form, as done in this interface, which you can view at https://publiclab.org/profile/info/your_username

So I think we'll need to start using the Google Geocoding API, so look into the links from the above list, especially the form here:

https://github.com/publiclab/plots2/blob/master/app/views/users/_tags_form.html.erb#L101

You can try this search-location-by-text interface here: https://publiclab.org/profile/info/warren (but with your own username)

[mridulnagpal]

@jywarren Okay so I studied the code for the API but how do I implement it for this one?

[jywarren]

Hi, Mridul - why don't you try copying in the key portions of the form from the other document, and we'll see how it runs?

[mridulnagpal]

@jywarren What is our API_KEY for geocoding API?

[jywarren]

I think we can't share that out publicly, but you should be able to get your own. But now that I think about it, i'm not sure it's required anymore! Are you sure?

[mridulnagpal]

How do I import the autocomplete method if I can't import the object google? Is there any other way to Import google?

[jywarren]

Hi, Mridul, perhaps we should open a new issue for this, as we're making a very long comments thread on this more general issue. But i looked and apologies, it looks like the Google Maps API and key are shown here: https://github.com/publiclab/plots2/blob/master/app/views/users/info.html.erb#L8

[mridulnagpal]

@jywarren What's next?

[jywarren]

HI, @mridulnagpal - I notice that the update doesn't happen until you deselect the search form box, do you think you could make it happen upon selecting a place?

Next up will be a method to get the northwest corner of the current box, then working down the list above. I've been checking them off as we go!

Thanks!

[jywarren]

OK, lots just moved over to: publiclab/leaflet-blurred-location#1 -- this will continue, though plots2-side issues will remain here.

[jywarren]

OK, i'm now closing this and will open a new one for those plots2-side functions we'll need!

[mridulnagpal]

@jywarren Can you check off the points that have been completed

[jywarren]

Yep!