Small UI fix for All maps

[divyabaid16]

Fixes #797 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[divyabaid16]

Hi @cesswairimu can you have a look at this?
Thanks!

[codeclimate]

Code Climate has analyzed commit 66b40bea and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #801 into main will decrease coverage by 2.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
- Coverage   72.43%   70.28%   -2.15%     
==========================================
  Files          35       35              
  Lines        1335     1353      +18     
==========================================
- Hits          967      951      -16     
- Misses        368      402      +34

Impacted Files	Coverage Δ
app/controllers/annotations_controller.rb	0% <0%> (-59.26%)	⬇️

[cesswairimu]

Looks good, Thanks. I am not sure why CodeCov is failing though 🤔

[jywarren]

Similarly to #802:

This is awesome! I think CodeCov is asking that any new PRs have at least the same coverage as the rest of the project. Which in this case maybe doesn't make sense. But we can add a functional or integration test perhaps to improve coverage of this page?

[jywarren]

OK, added a simple integration test! This is kind of weird that for changes like this we'd need to add tests. But we can test HTML code. So, for now, why not.

[jywarren]

I'm not sure why this is affecting the sessions controller. I guess it's because we touch code where there is a line based on whether you're logged in? Let me try adding a test to sessions controller i guess...

[jywarren]

Hmm. https://docs.codecov.io/docs/unexpected-coverage-changes

[jywarren]

Let me try rebasing this...

[jywarren]

I've asked @kaustubh-nair to see if we can narrow in on what's going on here a bit... in #810!

[divyabaid16]

Hi @kaustubh-nair the codecov failure in this and #825 is similar kind like failing for project and not for patch?
I'm sorry for asking a silly thing but I'm not aware of Codecov.

[kaustubh-nair]

No problem @divyabaid16!
I'm not entirely sure why codecov is behaving like this. I assumed it was due to having project turned on. But I've testing it out a bit more and I think the cause is something else.
But for now we can ignore the coverage decrease if a file's coverage drops to 0% since it's not actually possible. For example in this pull annotations_controller is down to 0.
I'm trying to fix this here #830 so sorry for any inconveniences till then!

[divyabaid16]

Okay!
Thanks @kaustubh-nair

[jywarren]

OK, thanks! I'll use admin privileges to merge this in the meantime. Thanks all!