Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured Mappers not shown in localhost #797

Closed
divyabaid16 opened this issue Jul 4, 2019 · 7 comments · Fixed by #801
Closed

Featured Mappers not shown in localhost #797

divyabaid16 opened this issue Jul 4, 2019 · 7 comments · Fixed by #801

Comments

@divyabaid16
Copy link
Contributor

Description
Even though the Featured mappers is shown in unstable and stable, it is not shown in localhost.
I have pulled the lastest changes.

Selection_196

@cesswairimu @jywarren

@jywarren
Copy link
Member

jywarren commented Jul 4, 2019 via email

@divyabaid16
Copy link
Contributor Author

Ya, that can be done.
Maybe we can just remove | before All maps so that it seems complete?!
Do let me know if I can help here in some way.
Thanks!

@cesswairimu
Copy link
Collaborator

Yeah we should move the | in the if block... Would you like to change that? Thanks @divyabaid16

@divyabaid16
Copy link
Contributor Author

Ya, I will do it.
Thanks!

@divyabaid16
Copy link
Contributor Author

After solving for this issue I think that we don't need | at all. Because Featured Mappers is like a complete subsection. What do you think @cesswairimu ?

Maybe we can just delete | and I will create the FTO for this if it is fine?

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jul 4, 2019

I think we need it..beause if you have your location shared this is how the interface looks like..

maps

Or maybe you have ideas of a better display? We could explore other ideas

@divyabaid16
Copy link
Contributor Author

Oh yeah, you're right. I will just do it.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants