-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale homepage modal buttons #1606
Conversation
Thanks for opening this pull request! |
Code Climate has analyzed commit 02780ff and detected 0 issues on this pull request. View more on Code Climate. |
app/views/front_ui/index.html.erb
Outdated
<a class="btn btn-primary btn-lg" href= 'https://store.publiclab.org/collections/mapping-kits'> | ||
Get a mapping kit <i class="fa fa-angle-double-right fa-fw" style="font-size:18px;color:white;"></i> | ||
</a> | ||
<% if logged_in? %> | ||
<a class="btn btn-primary btn-lg" href="<%= new_map_url %>"> | ||
<a class="btn btn-primary btn-lg" href="<%= new_map_url %>" style="display:flex; align-content:center; flex-wrap:wrap; justify-content:center;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refactor these duplicated inline styles into .modal-buttons a
selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I'll do that
@VladimirMikulic I have updated the changes.. can you please take a look. Thanks |
I'm trying to fix some unrelated dependency issues in #1616 which should unblock this -- we'll need to rebase again, but hang on and let me try to get this working! |
Codecov Report
@@ Coverage Diff @@
## main #1606 +/- ##
==========================================
- Coverage 72.98% 71.54% -1.45%
==========================================
Files 40 40
Lines 1399 1409 +10
==========================================
- Hits 1021 1008 -13
- Misses 378 401 +23
|
#1616 succeeded!!!! Can you rebase this over the latest main branch? I believe it will then pass. Thank you!!! |
eb0e5c1
to
f58ce43
Compare
Did I do something wrong? I had to resolve some merge conflicts, not sure if I did it right 😞 |
Hi, I'm so sorry to reply late. I'm going to try rebasing this over the latest main branch and I /think/ it will resolve -- nothing you did wrong, in any case! |
f58ce43
to
e7450ba
Compare
OK, rebased! Let's see - 🤞 |
e7450ba
to
2153688
Compare
2153688
to
0b53472
Compare
OK phew, sorry that took a while, it's merged now! Thank you!! |
Fixes #1174 (<=== Add issue number here)
Scaled homepage modal buttons so that they are of the same height on all screens
modal-buttons.mp4
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment below