Modal buttons not scaled solved

[ghost]

Hey added given code to make modal buttons have same height on all screen sizes.

Fixes #1174 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[codeclimate]

Code Climate has analyzed commit 60f0326 and detected 0 issues on this pull request.

View more on Code Climate.

[codecov]

Codecov Report

Merging #1176 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1176   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files          40       40           
  Lines        1400     1400           
=======================================
  Hits         1021     1021           
  Misses        379      379

[ghost]

Hey can someone review the solution I submitted thank u :)

[VladimirMikulic]

@Johongirr congratulations 🎉

[VladimirMikulic]

@sashadev-sky @jywarren we can merge this.

[ghost]

thank u very much this was wonderful experience

[ghost]

#1176

[VladimirMikulic]

#1176

It's #1174, this binds issue with the corresponding PR :)

[ghost]

#1174

[cesswairimu]

Hi @Johongirr, thanks for opening this..I pulled this and it doesn't look right... This is the view from mobile

could you please recheck?

[ghost]

Hi cesswairimu, I did not get it. I did steps he gave on the instruction and now I checked from my phone and it looked the same as the time when he opened issue. in what screen size this happened? thanks

[sashadev-sky]

@VladimirMikulic do you have any follow-ups here about the contributor's question above?

[VladimirMikulic]

@sashadev-sky Unfortunately, I don't.

[sashadev-sky]

ok ill check it out sometime later today hopefully

[cesswairimu]

Hi, it seems the issue was fixed in this PR. Sorry for the confusion Closing this. Thanks