-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default action from warp to resize #183
Comments
Very excellent idea. |
+100000000000000 txt only: +1 336-269-1539 On Mon, Jun 22, 2015 at 1:12 PM, Fastie notifications@github.com wrote:
|
We discussed this originally when developing the Leaflet.DistortableImage plugin, but worried that people would think the plugin could only do rotation/scaling. There's also been a request yesterday for this on the plugin itself (publiclab/Leaflet.DistortableImage#51) suggesting that this would be helpful not just in the MapKnitter instance but in general. But how to reconcile this? Ann and I were brainstorming a bit, and I thought we could indicate rotation vs. distortion with some kind of icon indicator, like this: But it's a bit crude, and it does obscure part of the image, though not near the edges where it's most important. @wmaiouiru, any thoughts on this solution? |
@jywarren I think the icon indication would be a nice touch, but would it be hard to let the developer define default behavior on startup? I foresee the possibility that some users might want to use the distort behavior as default. |
interesting! Regarding the worry that "people would think the plugin could Can the dual concepts of rotation/scale and distortion be somehow txt only: +1 336-269-1539 On Tue, Jun 23, 2015 at 1:02 PM, William Maio notifications@github.com
|
Oh interesting. Rotation/scaling is, when you think about it in code, a subset of distortion -- like, it's easier. So my take on it as an author has been that people would assume we'd just done the easier thing. But from a user perspective the two are kind of on a level. I agree, the icon is heavy-handed, but we don't have a lot of latitude in design in the toolbar. Can you think of a way to visually communicate what we're getting at in the toolbar? We could try to color rotate/distort red, or place it to the left, or something? These don't seem very strong indicators to me. |
I agree that the icon on the image is not needed. New MapKnitter users should always start by rotating and scaling. If they are not capable of finding the button for distort, they will not be able to do anything else in MapKnitter either, so that's another issue. Advanced MapKnitter users should almost always start with rotate/scale as well, and advanced users who want to distort will quickly find how easy it is to switch. Users of Leaflet.DistortableImage in applications other than MapKnitter may have other considerations. |
I'm just worried about our original doubt -- that users would show up and It'd be a bit odd, but we could do distortion-first only the first time a I'm going to leave this for tomorrow when my vacation is over, but thanks On Tue, Jun 23, 2015 at 1:42 PM, Fastie notifications@github.com wrote:
|
Further input? |
I'm late to this thread. I wonder why with warp set first, people would think there is a Jeff, did you already test this out on users to come to that conclusion? The icon on top is a bit heavyhanded, I agree with Liz. What if the warp icon and rotate/resize icons sat side by side in the On Mon, Jul 6, 2015 at 8:07 AM, Jeffrey Warren notifications@github.com
|
Well, many interfaces offer rotation/scale - any drawing program, most GIS programs, etc. But warping is a more advanced feature to implement and is pretty rare to see in a graphics environment of any kind. For example, in Photoshop and Gimp, there isn't even a tool on the tool bar for it, where there is for rotate/scale. Many GIS applications (like Google Earth, for example) offer rotate/scale/shear, but not warp. We could definitely make two separate buttons, but I think we still have the question of how to introduce warping to people, and which to have as a default. Do people like the idea of a separate rotation handle, which is a strong and familiar convention? This eliminates the "which first" debate. |
I haven't done a user test, no -- but we could set one up at an upcoming event, perhaps? |
Hi! I am late this game but looks like this issue is still relevant. My thoughts are these:
Comprehensive Plan so far (feel free to add on anything here, @jywarren, @ebarry @annhchen, @everyonelse)
|
Another aspect of this is that distort can leave an image accidentally
distorted incorrectly for a first time user. There may be other ways to
address this too, though, like:
1. An easy undo action
2. An easy "revert to original" action
Thanks!
…On Fri, May 17, 2019, 2:45 PM Sasha Boginsky ***@***.***> wrote:
Hi! I am late this game but looks like this issue is still relevant. My
thoughts are these:
-
Distort is a much more rarely seen editing tool compared to RotateScale,
which is pretty standard. So personally, I think staying on distort makes
sense.
-
Swapping them is also not a real solution to the question of making it
clear to a user which editing tools they have at their disposal. It is
trading in one problem for another. This issue will need to be addressed in
a more comprehensive way...
*Comprehensive Plan so far* (feel free to add on anything here, @jywarren
<https://github.com/jywarren>, @ebarry <https://github.com/ebarry>
@annhchen <https://github.com/annhchen>, @everyonelse)
1.
Our first step is introducing (see PR here
<publiclab/Leaflet.DistortableImage#206>) a
new *optional* option, mode into our API. It allows a user to specify
their preferred initial editing tool during L.distortableImageOverlay
initialization
- There have been a few request for rotate specifically, but the user
can any of our available editing modes, the world is their oyster.
- If a mode option is not set at all, initial editing mode defaults
to "distort"
- Check out the *Mode* section
<https://github.com/publiclab/Leaflet.DistortableImage#mode> in our
README for someone additional information on using this option and a code
block example.
2.
*UP in the air*
I think the next task here is to create a UI that shows the user off
the bat, all the different types 0f things they can do. This means *compartmentalized
categories of tools*. Separating "styling" editing actions, such as
opacity and brightness into a separate section from Transform related
actions (rotate, scale, distort).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#183?email_source=notifications&email_token=AAAF6J42ZRUBQ2ZXFGJTQR3PV34JLA5CNFSM4BJENDRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVRVOI#issuecomment-493558457>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J66Z6SEFIBDV6CHPCLPV34JLANCNFSM4BJENDRA>
.
|
@jywarren Ok closing this out and moving relating comments from here into a new issue :) |
@jywarren Can you please go into the implications of this in the context of this discussion? I am not grasping what you mean |
This is a user flow recommendation rather than a bug report
The current default setting for a photo after it is placed on the map is set to warp (the grey button). In my experience using MapKnitter, almost 100% of the time, I resize and rotate the image before warping. As a result, I sometimes accidentally warp the image when I mean to resize it.
Suggestion:
Switch the default setting from warp to the resize/rotate (red).
Public username: ann
Browser: Chrome V. 43
The text was updated successfully, but these errors were encountered: