Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files in beacon-chain/operations/slashings #14904

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Feb 10, 2025

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

To make the diff of #14844 more readable, I added the code for the service inside service_new.go and kept the code of the pool in service.go. This PR cleans that up by moving the code of the pool to pool.go and the code for the service to service.go.

Acknowledgements

@rkapka rkapka added the Cleanup Code health! label Feb 10, 2025
@rkapka rkapka requested a review from a team as a code owner February 10, 2025 12:11
@rkapka rkapka requested review from saolyn, potuz and nisdas February 10, 2025 12:11
@rkapka rkapka enabled auto-merge February 10, 2025 12:11
@rkapka rkapka force-pushed the rename-slashing-files branch from a3ce034 to d376e6b Compare February 10, 2025 12:24
@rkapka rkapka force-pushed the rename-slashing-files branch from d376e6b to 3bab30a Compare February 10, 2025 12:40
nalepae
nalepae previously approved these changes Feb 10, 2025
@rkapka rkapka added this pull request to the merge queue Feb 11, 2025
Merged via the queue into develop with commit 0229a20 Feb 11, 2025
17 checks passed
@rkapka rkapka deleted the rename-slashing-files branch February 11, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants