Convert Phase0 slashing to Electra slashings at the fork #14844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
commented
Jan 30, 2025
| @@ -270,6 +270,32 @@ func (p *Pool) MarkIncludedProposerSlashing(ps *ethpb.ProposerSlashing) { | |||
| numProposerSlashingsIncluded.Inc() | |||
| } | |||
|
|
|||
| // ConvertToElectra converts all Phase0 attester slashings to Electra attester slashings. | |||
| // This functionality is needed at the time of the Electra fork. | |||
| func (p *Pool) ConvertToElectra() { | |||
There was a problem hiding this comment.
This is tested in beacon-chain/operations/slashings/service_new_test.go
rkapka
commented
Jan 30, 2025
| ) | ||
|
|
||
| // WithElectraTimer includes functional options for the blockchain service related to CLI flags. | ||
| func WithElectraTimer(cw startup.ClockWaiter, currentSlotFn func() primitives.Slot) Option { |
There was a problem hiding this comment.
The reason why the parameter is a func, and not a struct or interface, is because we would need to pass in the chain service, which creates a cyclic dependency that is very hard to fix.
rkapka
changed the title
SlashingPoolService
nalepae
approved these changes
Jan 30, 2025
This was referenced Feb 4, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
The PR adds a
SlashingPoolService, whose function is to convert Phase0 slashing in the slashing pool into Electra slashings. Phase0 slashings will become invalid at the fork, so without this they would get lost.Acknowledgements