Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move log setup to reduce cyclomatic complexity #13732

Closed
wants to merge 1 commit into from

Conversation

kasey
Copy link
Contributor

@kasey kasey commented Mar 12, 2024

What type of PR is this?

Other - deepsource appeasement

What does this PR do? Why is it needed?

While working on a different PR I got a complaint from deepsource about the cyclomatic complexity of main(). Rather than fix it there, I silenced the error in the other branch and broke out this separate PR to resolve it.

@kasey kasey requested a review from a team as a code owner March 12, 2024 21:28
@kasey kasey enabled auto-merge March 12, 2024 22:32
@nalepae
Copy link
Contributor

nalepae commented Mar 13, 2024

Already handled by 024ae3a in this pull request: #13719. (To be merged)

I think you can close this one.

@kasey kasey closed this Mar 14, 2024
auto-merge was automatically disabled March 14, 2024 17:45

Pull request was closed

@kasey kasey deleted the simplify-main-cyclomatic branch March 14, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants