Backfill min slot flag #13729
Merged
Backfill min slot flag #13729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
backfill-min-slot-flag
branch
from
0edca40 to
5c87237
Compare
kasey
force-pushed
the
backfill-min-slot-flag
branch
from
dab14a3 to
5588694
Compare
nisdas
approved these changes
Mar 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds the ability to control the slot where the backfill operation will be marked complete. This flag only allows specifying a slot that is older than
<current_slot> - MIN_EPOCHS_FOR_BLOCK_REQUESTS. If the specified slot is newer than that, it will be ignored with a warning log. Setting a value of0allows backfilling to genesis.Note that this flag does not change the behavior of the backfill process with regard to blobs. Blobs outside the retention window still will not be downloaded, as nodes may be unable to find peers capable of serving expired blobs and requiring them to be present would create complexities re peer scoring and delay syncing for the majority of nodes that do not need expired blobs.