Enforce log.WithError(err) static analysis and fix all violations #11163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, fixing tests... |
potuz
reviewed
Aug 3, 2022
potuz
reviewed
Aug 3, 2022
Co-authored-by: Potuz <potuz@prysmaticlabs.com>
potuz
reviewed
Aug 3, 2022
|
|
|
Thank you for contributing to the repo! Please sign the CLA before we can proceed 😆 |
prestonvanloon
force-pushed
the
use-sa-from-11143
branch
from
65a9e5c to
b4e0106
Compare
potuz
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Enables the static analysis from #11143 and fixes all violations.
Which issues(s) does this PR fix?
Other notes for review