Static Analyzer: require log.WithError instead of log.Errorf("bad: %v", err) #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
approved these changes
Aug 1, 2022
|
Nice! |
prestonvanloon
added a commit
that referenced
this pull request
Aug 3, 2022
prylabs-bulldozer bot
added a commit
that referenced
this pull request
Aug 5, 2022
…1163) * Use log.WithError static analysis from #11143 and fix all violations * Fix another log violation after pulling from develop * Update beacon-chain/sync/pending_blocks_queue.go Co-authored-by: Potuz <potuz@prysmaticlabs.com> * @potuz feedback * Copy paste fail * fix tests Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Potuz <potuz@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This is a follow up to #11116 where I mentioned that I would be adding enforcement to use log.WithError() instead of templated log messages.
In this PR, I have implemented the static analysis check and appropriate test. I have not enabled this check in the codebase yet as it would make this PR very large.
Enabling the check and fixing the dozens of templated log statements with errors will follow in another PR.
Which issues(s) does this PR fix?
Fixes #
Other notes for review