Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a CheckConstraint Min and Max function where the expected is a Nullable type #27045

Merged
merged 12 commits into from
Jun 12, 2023
Merged

Added a CheckConstraint Min and Max function where the expected is a Nullable type #27045

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
658bdef
Added a CheckConstraint Min and Max function where the expected is a …
mhazley Jun 2, 2023
105b8ee
Merge branch 'master' of github.com:dysonltd/connectedhomeip into add…
mhazley Jun 5, 2023
40e8253
Reversed the null check as it was wrong way around. Fixed new paramet…
mhazley Jun 5, 2023
2251fff
Merge remote-tracking branch 'origin' into add-support-for-nullable-f…
mhazley Jun 5, 2023
c28d886
Merge remote-tracking branch 'origin' into add-support-for-nullable-f…
mhazley Jun 6, 2023
ddc6063
Fixed return parameters
mhazley Jun 6, 2023
044b41d
Fixed return parameters
mhazley Jun 6, 2023
f6ba488
Removed enable_if_t from new template functions
mhazley Jun 7, 2023
abeb8f8
Merge remote-tracking branch 'origin' into add-support-for-nullable-f…
mhazley Jun 7, 2023
c76b04d
Merge branch 'master' into add-support-for-nullable-float-in-constrai…
mhazley Jun 9, 2023
28da44a
Merge branch 'master' into add-support-for-nullable-float-in-constrai…
mhazley Jun 9, 2023
01328a7
Merge branch 'master' into add-support-for-nullable-float-in-constrai…
mhazley Jun 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/app/tests/suites/include/ConstraintsChecker.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,17 @@ class ConstraintsChecker
return CheckConstraintMinValue(itemName, current.Value(), static_cast<T>(expected));
}

template <typename T, typename U, std::enable_if_t<!std::is_pointer<U>::value, int> = 0>
bool CheckConstraintMinValue(const char * itemName, const chip::app::DataModel::Nullable<T> & current,
chip::app::DataModel::Nullable<U> expected)
{
if (current.IsNull())
{
return true;
}
return CheckConstraintMinValue(itemName, current.Value(), static_cast<T>(expected.Value()));
}

template <typename T, typename U>
bool CheckConstraintMinValue(const char * itemName, const T & current, const chip::Optional<U> & expected)
{
Expand Down Expand Up @@ -375,6 +386,17 @@ class ConstraintsChecker
return CheckConstraintMaxValue(itemName, current.Value(), static_cast<T>(expected));
}

template <typename T, typename U, std::enable_if_t<!std::is_pointer<U>::value, int> = 0>
bool CheckConstraintMaxValue(const char * itemName, const chip::app::DataModel::Nullable<T> & current,
chip::app::DataModel::Nullable<U> expected)
{
if (current.IsNull())
{
return true;
}
return CheckConstraintMaxValue(itemName, current.Value(), static_cast<T>(expected.Value()));
}

template <typename T, typename U>
bool CheckConstraintMaxValue(const char * itemName, const T & current, const chip::Optional<U> & expected)
{
Expand Down