-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a CheckConstraint Min and Max function where the expected is a Nullable type #27045
Merged
andy31415
merged 12 commits into
project-chip:master
from
dysonltd:add-support-for-nullable-float-in-constraints-checking-code
Jun 12, 2023
Merged
Added a CheckConstraint Min and Max function where the expected is a Nullable type #27045
andy31415
merged 12 commits into
project-chip:master
from
dysonltd:add-support-for-nullable-float-in-constraints-checking-code
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #27045: Size comparison from e19d9d8 to 658bdef Increases (8 builds for bl702, esp32, psoc6, telink)
Decreases (9 builds for bl602, esp32, psoc6, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
reviewed
Jun 2, 2023
bzbarsky-apple
requested changes
Jun 2, 2023
…-support-for-nullable-float-in-constraints-checking-code
…er to reference and const
…loat-in-constraints-checking-code
PR #27045: Size comparison from 13cd63a to 2251fff Increases (10 builds for bl602, esp32, psoc6, qpg, telink)
Decreases (10 builds for bl602, bl702, cc32xx, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…loat-in-constraints-checking-code
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #27045: Size comparison from e5fd871 to 044b41d Increases (4 builds for esp32, psoc6, telink)
Decreases (12 builds for bl602, cc32xx, esp32, psoc6, qpg, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jun 6, 2023
…loat-in-constraints-checking-code
PR #27045: Size comparison from 2520f47 to abeb8f8 Increases (9 builds for bl602, bl702, cc32xx, esp32, psoc6, telink)
Decreases (4 builds for telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
…nts-checking-code
PR #27045: Size comparison from 530349a to c76b04d Increases (5 builds for bl702, cc32xx, cyw30739, k32w, psoc6)
Decreases (7 builds for bl602, bl702, esp32, k32w, psoc6)
Full report (40 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
andy31415
approved these changes
Jun 9, 2023
cecille
approved these changes
Jun 9, 2023
…nts-checking-code
PR #27045: Size comparison from 50654bf to 28da44a Increases (8 builds for bl702, k32w, telink)
Decreases (12 builds for bl602, bl702, k32w, mbed, psoc6, telink)
Full report (54 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
…nts-checking-code
PR #27045: Size comparison from 40fb7c2 to 01328a7 Increases (8 builds for cyw30739, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc32xx, esp32, k32w, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tobiasgraf
approved these changes
Jun 12, 2023
p0fi
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR came about when generating test YAML for the concentration measurement clusters. I needed to check constraints on a nullable float and after regenning the tests,
chip-tool
build was failing.The error was:
So, I added these two new templates to support the checks in my YAML.