Fix RR_1.1 to add_all_groups to add right amount of groups per endpoint #25767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bring code in line to what is actually written in the RR_1.1 spec. There was a bug in add_all_groups that wrote all wrote all the groups to each of the endpoints instead, leading to writting more then the maximum of supported groups per fabric.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #25767: Size comparison from 934a6b1 to a384917 Decreases (2 builds for cc32xx, qpg)
Full report (5 builds for cc32xx, linux, qpg)
|
bzbarsky-apple
approved these changes
Mar 21, 2023
| @@ -644,11 +644,17 @@ async def add_all_groups(self, | |||
|
|
|||
| base_groups_per_endpoint: int = math.floor(groups_per_fabric / len(group_endpoints)) | |||
| groups_remainder: int = groups_per_fabric % len(group_endpoints) | |||
| fabric_group_index: int = 0 | |||
|
|
|||
| group_id_list = [group_id for group_id in (group_key_map[client_idx])] | |||
There was a problem hiding this comment.
Suggested change
| group_id_list = [group_id for group_id in (group_key_map[client_idx])] | |
| group_id_list = list(group_key_map[client_idx]) |
might be clearer, but either way. And maybe call it group_id_list_copy?
tehampson
commented
Mar 21, 2023
| @@ -644,11 +644,17 @@ async def add_all_groups(self, | |||
|
|
|||
| base_groups_per_endpoint: int = math.floor(groups_per_fabric / len(group_endpoints)) | |||
| groups_remainder: int = groups_per_fabric % len(group_endpoints) | |||
| fabric_group_index: int = 0 | |||
|
|
|||
There was a problem hiding this comment.
After chatting on this issue we have filed https://github.com/CHIP-Specifications/chip-test-plans/issues/2502. As a result the code here will need to change again to properly test. As a results I am moving this PR to a draft to wait on feedback on if https://github.com/CHIP-Specifications/chip-test-plans/issues/2502 is in fact what we want Step 14 of this test to be actually doing.
|
LGTM % comment |
|
This PR is incorporated into #25789 which contains additional fixes to resolve the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bring code in line to what is actually written in the RR_1.1 spec. There was a bug in add_all_groups that wrote all wrote all the groups to each of the endpoints instead, leading to writting more then the maximum of supported groups per fabric.
One of the 4 PRs needed to fix #25532