-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Render signal event #408
Merged
csouchet
merged 14 commits into
process-analytics:master
from
benjaminParisel:render_signal_start_event
Jul 22, 2020
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c8670ab
Render signal start event
benjaminParisel 3671c80
restore markNonFullyRenderedEvents for next event to support
tbouffard 5ddc0d6
Merge branch 'master' into render_signal_start_event
tbouffard 1cf409d
fix lint error (unused var)
tbouffard 1682f1d
1st attempt for stroke width
tbouffard bf87327
revert useless BpmnCanvas change (move property)
tbouffard 0d29f85
revert useless BpmnCanvas change (move property)
tbouffard 86efc98
revert useless BpmnCanvas change (restore readonly property)
tbouffard de7b875
Merge branch 'master' into render_signal_start_event
tbouffard 76ed8b0
update doc and link to original triangle icon
tbouffard 29cb3fd
center signal event icon
tbouffard 8409d65
Merge branch 'master' into render_signal_start_event
csouchet 5f2ca00
Merge branch 'master' into render_signal_start_event
csouchet 398e088
Fix ratio from parent & stroke width of signal icon
csouchet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's normal that the strokeWidth change the ratio from the shape, because MxGraph increase the size of the icon when the stroke width is greater than 1.
So to keep consistency and have the same size of an icon (whatever its stroke width), the ratio from the shape change 😉