-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Render signal event #408
[FEAT] Render signal event #408
Conversation
* MISC icon is not really center
Rendering with commit c8670ab It includes a preview of the #404 refactoring. The icon is currently not centered, I have worked with @benjaminParisel on the topic but we currently don't know why the icon is not fully centered (issue on the scaling factor computation? something else?) |
Render with 29cb3fdImplementation NotesWe should rework the scaling and origin position computing in the future
|
style: icon, | ||
}, | ||
}); | ||
c.setStrokeWidth(StyleDefault.STROKE_WIDTH_THIN); // TODO should be done via icon style, but in that case, the strokeWidth change the ratio from shape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's normal that the strokeWidth change the ratio from the shape, because MxGraph increase the size of the icon when the stroke width is greater than 1.
So to keep consistency and have the same size of an icon (whatever its stroke width), the ratio from the shape change 😉
At commit 398e088 |
When you merge your refactoring on the painter, i guess you need to manage conflicts 👀
closes #220
closes #221
closes #401
closes #402
Remaining tasks