-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): add unicorn/prefer-ternary
rule
#2870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
♻️ PR Preview 6a8f040 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
♻️ PR Preview 6a8f040 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
unicorn/prefer-dom-node-text-content
ruleunicorn/prefer-ternary
rule
4818c1d
to
e80c818
Compare
e80c818
to
6a8f040
Compare
tbouffard
approved these changes
Sep 21, 2023
} else { | ||
receivedCell.overlays = undefined; | ||
} | ||
receivedCell.overlays = cellOverlays?.map(cellOverlay => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: nice!
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
refactoring
Code refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid to have to many changes by enabling
plugin:unicorn/recommended
, I choose to enable some rule one-by-one.https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-ternary.md
Part of #2824
Covers #2742