chore(eslint): add unicorn/prefer-ternary rule (#2870)

.eslintrc.cjs

@@ -45,6 +45,7 @@ module.exports = {
     'unicorn/prefer-add-event-listener': 'error',
     'unicorn/no-array-for-each': 'error',
     'unicorn/prefer-dom-node-text-content': 'error',
+    'unicorn/prefer-ternary': 'error',
     'import/newline-after-import': ['error', { count: 1 }],
     'import/first': 'error',
     'import/order': [

scripts/utils/parseBpmn.ts

@@ -48,11 +48,7 @@ const json = xmlParser.parse(readFileSync(bpmnFilePath, 'utf-8', __dirname));
 const prettyString = (object: BpmnJsonModel | BpmnModel): string => JSON.stringify(object, null, 2);
 
 let result = '';
-if (outputType === 'json') {
-  result = prettyString(json);
-} else {
-  result = prettyString(newBpmnJsonParser(new ParsingMessageCollector()).parse(json));
-}
+result = outputType === 'json' ? prettyString(json) : prettyString(newBpmnJsonParser(new ParsingMessageCollector()).parse(json));
 
 // copy to clipboard
 // disabling the copy is not officially supported, it currently fails on GitHub actions when running on Ubuntu 20.04. So disabling it only in this case.

src/component/mxgraph/shape/activity-shapes.ts

@@ -82,20 +82,16 @@ export abstract class BaseActivityShape extends mxRectangleShape {
   }
 
   private getMarkerIconOriginFunction(allMarkers: number, markerOrder: number): (canvas: BpmnCanvas) => void {
-    let setIconOriginFunction: (canvas: BpmnCanvas) => void;
-    if (allMarkers === 1) {
-      setIconOriginFunction = (canvas: BpmnCanvas) => canvas.setIconOriginForIconBottomCentered();
-    }
-    // Here we suppose that we have 'allMarkers === 2'
-    // More markers will be supported when implementing adhoc subprocess or compensation marker
-    else {
-      setIconOriginFunction = (canvas: BpmnCanvas) => {
-        canvas.setIconOriginForIconBottomCentered();
-        const xTranslation = Math.pow(-1, markerOrder) * (StyleDefault.SHAPE_ACTIVITY_MARKER_ICON_SIZE / 2 + StyleDefault.SHAPE_ACTIVITY_MARKER_ICON_MARGIN);
-        canvas.translateIconOrigin(xTranslation, 0);
-      };
-    }
-    return setIconOriginFunction;
+    return allMarkers === 1
+      ? (canvas: BpmnCanvas) => canvas.setIconOriginForIconBottomCentered()
+      : (canvas: BpmnCanvas) => {
+          // Here we suppose that we have 'allMarkers === 2'
+          // More markers will be supported when implementing adhoc subprocess or compensation marker
+
+          canvas.setIconOriginForIconBottomCentered();
+          const xTranslation = Math.pow(-1, markerOrder) * (StyleDefault.SHAPE_ACTIVITY_MARKER_ICON_SIZE / 2 + StyleDefault.SHAPE_ACTIVITY_MARKER_ICON_MARGIN);
+          canvas.translateIconOrigin(xTranslation, 0);
+        };
   }
 }
 

src/component/parser/json/converter/ProcessConverter.ts

@@ -350,11 +350,7 @@ export default class ProcessConverter {
     } else {
       const sourceShapeBpmnElement = this.convertedElements.findFlowNode(sequenceFlow.sourceRef);
       if (sourceShapeBpmnElement && ShapeUtil.isWithDefaultSequenceFlow(sourceShapeBpmnElement.kind) && sequenceFlow.conditionExpression) {
-        if (ShapeUtil.isActivity(sourceShapeBpmnElement.kind)) {
-          return SequenceFlowKind.CONDITIONAL_FROM_ACTIVITY;
-        } else {
-          return SequenceFlowKind.CONDITIONAL_FROM_GATEWAY;
-        }
+        return ShapeUtil.isActivity(sourceShapeBpmnElement.kind) ? SequenceFlowKind.CONDITIONAL_FROM_ACTIVITY : SequenceFlowKind.CONDITIONAL_FROM_GATEWAY;
       }
     }
     return SequenceFlowKind.NORMAL;

test/config/jest-playwright.cjs

@@ -109,11 +109,8 @@ const computeConfigurationForDevelopmentServerUsage = defaultBrowsers => {
 
 const computeConfiguration = options => {
   let configuration;
-  if (options.startWebServer ?? true) {
-    configuration = computeConfigurationForDevelopmentServerUsage(options.defaultBrowsers);
-  } else {
-    configuration = computeConfigurationForStaticUsage(options.defaultBrowsers);
-  }
+  configuration =
+    options.startWebServer ?? true ? computeConfigurationForDevelopmentServerUsage(options.defaultBrowsers) : computeConfigurationForStaticUsage(options.defaultBrowsers);
   log('Computed configuration', configuration);
   return configuration;
 };

test/integration/matchers/matcher-utils.ts

@@ -236,16 +236,12 @@ export function buildReceivedCellWithCommonAttributes(cell: mxCell): ExpectedCel
   const receivedCell = buildBaseReceivedExpectedCell(cell);
 
   const cellOverlays = bpmnVisualization.graph.getCellOverlays(cell) as MxGraphCustomOverlay[];
-  if (cellOverlays) {
-    receivedCell.overlays = cellOverlays.map(cellOverlay => ({
-      label: cellOverlay.label,
-      horizontalAlign: cellOverlay.align,
-      verticalAlign: cellOverlay.verticalAlign,
-      style: cellOverlay.style,
-    }));
-  } else {
-    receivedCell.overlays = undefined;
-  }
+  receivedCell.overlays = cellOverlays?.map(cellOverlay => ({
+    label: cellOverlay.label,
+    horizontalAlign: cellOverlay.align,
+    verticalAlign: cellOverlay.verticalAlign,
+    style: cellOverlay.style,
+  }));
 
   // The cell of the "message flow icon" is defined as a child of the "message flow" cell
   if (cell.edge) {

test/unit/helpers/JsonBuilder.ts

@@ -399,11 +399,7 @@ function addElementsOnProcess(processParameter: BuildProcessParameter, json: Bpm
 }
 
 function getElementOfArray<T>(object: T | T[], index = 0): T {
-  if (Array.isArray(object)) {
-    return object[index];
-  } else {
-    return object;
-  }
+  return Array.isArray(object) ? object[index] : object;
 }
 
 function enrichBpmnElement<T extends TBaseElement | DiagramElement>(currentElement: T | T[], elementToAdd: T): T | T[] {