[TEST] Add more DOM integration tests #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We load a file with all supported BPMN elements to ensure we don't have any issue when producing the SVG. The code coverage increases significantly as we now pass in all custom `mxGraph` shapes when running the new tests. For instance, the integration tests coverage for statements increases from `68.45%` to `93.04%`.
tbouffard
added
the
chore
|
♻️ PR Preview 5ac8a28 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud coverage estimation after PR merge: |
csouchet
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We load a file with all supported BPMN elements to ensure we don't have any
issue when producing the SVG.
The code coverage increases significantly as we now pass in all custom
mxGraphshapes when running the new tests. For instance, the integration tests coverage
for statements increases from
68.45%to93.04%.