Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Include e2e tests in the code coverage measure #924

Open
tbouffard opened this issue Dec 1, 2020 · 3 comments
Open

[INFRA] Include e2e tests in the code coverage measure #924

tbouffard opened this issue Dec 1, 2020 · 3 comments
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Comments

@tbouffard
Copy link
Member

tbouffard commented Dec 1, 2020

Coverage measured value of bpmn-visualization@0.8.0 in sonarcloud is 55.3%.
It doesn't count the code that is only tested through HTML page: this is mainly mxGraph extension code that we have decided to only tested in the Browser because we are interested in the final rendering more than what is in the DOM.

This is now more visible as we have made coverage percentage visible through SonarCloud.

See puppeteer coverage: https://pptr.dev/#?product=Puppeteer&version=v5.4.1&show=api-class-coverage

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Dec 1, 2020
@tbouffard tbouffard added this to the 0.9.0 milestone Dec 1, 2020
@csouchet csouchet modified the milestones: 0.9.0, 0.10.0 Dec 14, 2020
@tbouffard
Copy link
Member Author

tbouffard commented Jan 5, 2021

Temporar solution: to avoid the PR to be marked as failed, I have created a dedicated Sonar Quality Gate (based on the Sonar way Gate we previously used) that is now used by the project

image

@tbouffard
Copy link
Member Author

First attempt done with #1024: we are waiting for support of sourcemap to make the coverage use the Typescript code instead of the development bundle js code.

@tbouffard
Copy link
Member Author

#1193 highly increased the code coverage but we are still not using e2e tests for the coverage displayed in SonarCloud.

@tbouffard tbouffard changed the title [INFRA] Improve code coverage measure [INFRA] Include e2e tests in the code coverage measure May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants