Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password text boxes having distinguishable key sounds #9216

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Jun 5, 2020

Closes ppy/osu-framework#3280

Was aware of whether to create a dictionary holding all samples inside Keyboard resources folder (by some LINQ-ing and string manipulation) or store each sample in its own field, but chose the latter for simplicity.

@peppy peppy merged commit 63f42c5 into ppy:master Jul 10, 2020
@frenzibyte frenzibyte deleted the add-textbox-samples-and-fix-distingushing-passwords branch July 10, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password box has distinguishable key sounds
3 participants