Skip to content

Remove all audio-related logic from TextBox #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 10, 2020
Merged

Remove all audio-related logic from TextBox #3290

merged 7 commits into from
Jul 10, 2020

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Feb 20, 2020 •
edited
Loading

Prereqs:

Will be moved to osu!lazer.

Merge branch 'add-textbox-events-for-subclasses' into remove-sample-p…
87afae8 
…laying-from-textbox

# Conflicts:
#	osu.Framework/Graphics/UserInterface/TextBox.cs
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 4, 2020
@frenzibyte frenzibyte mentioned this pull request Jun 5, 2020
Merged
3 tasks
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 10, 2020
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 10, 2020
@peppy
Copy link
Member

peppy commented Jul 10, 2020

Added breaking change note for this.

@peppy peppy merged commit 0c3b3a6 into ppy:master Jul 10, 2020
@frenzibyte frenzibyte deleted the remove-sample-playing-from-textbox branch July 10, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach left review comments

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:UI size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frenzibyte @peppy @bdach @smoogipoo