Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove end note conversion in mania invert mod (causing unwanted jacks) #32357

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Remove end note conversion in mania invert mod (causing unwanted jacks) #32357

merged 1 commit into from
Mar 13, 2025

Conversation

Nunolin
Copy link
Contributor

@Nunolin Nunolin commented Mar 13, 2025 •
edited by smoogipoo
Loading

@smoogipoo
Copy link
Contributor

Makes sense to me. @peppy what special considerations do you think we need to make for already existing scores, if any?

@peppy
Copy link
Member

peppy commented Mar 13, 2025

Fine to leave them be IMO.

@Nunolin
Copy link
Contributor Author

Nunolin commented Mar 13, 2025

Are there any other changes needed? (This is my first time submitting a PR so I'm not too sure)

@peppy peppy requested a review from smoogipoo March 13, 2025 12:32
@smoogipoo
Copy link
Contributor

A good test for this one is maps that are already inverted, such as https://osu.ppy.sh/beatmapsets/352350#mania/776478

smoogipoo
smoogipoo approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@smoogipoo smoogipoo merged commit 0182893 into ppy:master Mar 13, 2025
8 of 10 checks passed
@Nunolin Nunolin deleted the mania-invert-end-notes branch March 13, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:gameplay area:mods ruleset/osu!mania size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

osu!mania "Invert" mod creates unwanted jacks
3 participants
@Nunolin @smoogipoo @peppy