Mania mod invert revork #27508
Mania mod invert revork #27508
Conversation
|
@DaiterGG Could you please make this mergable? This fix is quite needed ngl |
| [SettingSource("Invert Long Notes", "Invert long notes into nothing.")] | ||
| public BindableBool FullInvert { get; } = new BindableBool(); |
There was a problem hiding this comment.
needs a better description because i have no idea what this is supposed to be
also i assume the current logic for this in master is the same as if this was set to true. so either this will have to be changed to default to true, or all existing scores with invert in the database will need to be updated for correct playback. not sure what about replays either. i guess they'd just be hard-broken?
| (startTime: h.EndTime, samples: h.GetNodeSamples(1)) | ||
| })) | ||
| .OrderBy(h => h.startTime).ToList(); | ||
| List<(double startTime, IList<HitSampleInfo> samples, string type)> locations; |
There was a problem hiding this comment.
why is this using a string for type? use an enum? or bool even, if you must
| if (locations[i].type == "release") | ||
| continue; |
There was a problem hiding this comment.
doing this changes the behaviour of the mod completely, no? even if FullInvert is on?
this PR really needs a proper description because i have no idea what anything is here, and i shouldn't have to reverse-engineer the purpose of everything here from first principles
|
If I remember correctly, Checkbox off is - Extended |
Closes #25212
Treat hold note as one location
and
Add a checkbox option for different long note conversion