Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON property attributes from non-databased taiko difficulty attributes #32354

Merged
merged 1 commit into from
Mar 13, 2025

Remove JSON property attributes from non-databased taiko difficulty a…

db0676d
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Remove JSON property attributes from non-databased taiko difficulty attributes #32354

Remove JSON property attributes from non-databased taiko difficulty a…
db0676d
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Mar 12, 2025 in 0s

44050 passed, 2 failed and 360 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 11013✅ 90⚪ 2506s
TestResults-Linux-SingleThread.trx 11012✅ 1❌ 90⚪ 2102s
TestResults-Windows-MultiThreaded.trx 11013✅ 90⚪ 2988s
TestResults-Windows-SingleThread.trx 11012✅ 1❌ 90⚪ 2703s

✅ TestResults-Linux-MultiThreaded.trx

11103 tests were completed in 2506s with 11013 passed, 0 failed and 90 skipped.

❌ TestResults-Linux-SingleThread.trx

11103 tests were completed in 2102s with 11012 passed, 1 failed and 90 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Database.BackgroundDataStoreProcessorTests 23✅ 1❌ 13s

❌ osu.Game.Tests.Database.BackgroundDataStoreProcessorTests

✅ TestConstructor
✅ TestConstructor
✅ TestCustomRulesetScoreNotSubjectToUpgrades(False)
✅ TestCustomRulesetScoreNotSubjectToUpgrades(False)
✅ TestCustomRulesetScoreNotSubjectToUpgrades(True)
✅ TestCustomRulesetScoreNotSubjectToUpgrades(True)
✅ TestDifficultyProcessing
✅ TestDifficultyProcessing
✅ TestDifficultyProcessingWhilePlaying
✅ TestDifficultyProcessingWhilePlaying
❌ TestScoreUpgradeFailed(30000002)
	"Score marked as failed" timed out: Expected: True
	  But was:  False
	
✅ TestScoreUpgradeFailed(30000002)
✅ TestScoreUpgradeFailed(30000013)
✅ TestScoreUpgradeFailed(30000013)
✅ TestScoreUpgradeSuccess(30000001)
✅ TestScoreUpgradeSuccess(30000001)
✅ TestScoreUpgradeSuccess(30000002)
✅ TestScoreUpgradeSuccess(30000002)
✅ TestScoreUpgradeSuccess(30000003)
✅ TestScoreUpgradeSuccess(30000003)
✅ TestScoreUpgradeSuccess(30000004)
✅ TestScoreUpgradeSuccess(30000004)
✅ TestScoreUpgradeSuccess(30000005)
✅ TestScoreUpgradeSuccess(30000005)

✅ TestResults-Windows-MultiThreaded.trx

11103 tests were completed in 2988s with 11013 passed, 0 failed and 90 skipped.

❌ TestResults-Windows-SingleThread.trx

11103 tests were completed in 2703s with 11012 passed, 1 failed and 90 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Database.BackgroundDataStoreProcessorTests 23✅ 1❌ 16s

❌ osu.Game.Tests.Database.BackgroundDataStoreProcessorTests

✅ TestConstructor
✅ TestConstructor
✅ TestCustomRulesetScoreNotSubjectToUpgrades(False)
✅ TestCustomRulesetScoreNotSubjectToUpgrades(False)
✅ TestCustomRulesetScoreNotSubjectToUpgrades(True)
✅ TestCustomRulesetScoreNotSubjectToUpgrades(True)
✅ TestDifficultyProcessing
✅ TestDifficultyProcessing
✅ TestDifficultyProcessingWhilePlaying
✅ TestDifficultyProcessingWhilePlaying
✅ TestScoreUpgradeFailed(30000002)
❌ TestScoreUpgradeFailed(30000002)
	"Score marked as failed" timed out: Expected: True
	  But was:  False
	
✅ TestScoreUpgradeFailed(30000013)
✅ TestScoreUpgradeFailed(30000013)
✅ TestScoreUpgradeSuccess(30000001)
✅ TestScoreUpgradeSuccess(30000001)
✅ TestScoreUpgradeSuccess(30000002)
✅ TestScoreUpgradeSuccess(30000002)
✅ TestScoreUpgradeSuccess(30000003)
✅ TestScoreUpgradeSuccess(30000003)
✅ TestScoreUpgradeSuccess(30000004)
✅ TestScoreUpgradeSuccess(30000004)
✅ TestScoreUpgradeSuccess(30000005)
✅ TestScoreUpgradeSuccess(30000005)

Annotations

Check failure on line 186 in osu.Game.Tests/Database/BackgroundDataStoreProcessorTests.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Database.BackgroundDataStoreProcessorTests ► TestScoreUpgradeFailed(30000002) 

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  "Score marked as failed" timed out: Expected: True
    But was:  False
Raw output 
"Score marked as failed" timed out: Expected: True
  But was:  False

   at osu.Game.Tests.Database.BackgroundDataStoreProcessorTests.TestScoreUpgradeFailed(Int32 scoreVersion) in /home/runner/work/osu/osu/osu.Game.Tests/Database/BackgroundDataStoreProcessorTests.cs:line 186

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Database.BackgroundDataStoreProcessorTests ► TestScoreUpgradeFailed(30000002) 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  "Score marked as failed" timed out: Expected: True
    But was:  False
Raw output 
"Score marked as failed" timed out: Expected: True
  But was:  False

   at osu.Game.Tests.Database.BackgroundDataStoreProcessorTests.TestScoreUpgradeFailed(Int32 scoreVersion) in D:\a\osu\osu\osu.Game.Tests\Database\BackgroundDataStoreProcessorTests.cs:line 186
View more details on GitHub Actions