Remove JSON property attributes from non-databased taiko difficulty attributes #32354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
approved these changes
Mar 13, 2025
smoogipoo
approved these changes
Mar 13, 2025
|
Has been deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally pointed at
masterinstead ofpp-dev.For consumers of the difficulty attributes API endpoint, having these marked as JSON properties is wildly confusing. Since they're not databased, they're not set when getting a response from
osu-beatmap-difficulty-lookup-cacheso they just get returned as zeros always. These attributes exist despite being databased so that they're visible in osu-tools, but outside of that they don't really serve a purpose. JSON members are opt-in on difficulty attributes, so we can just remove these and makes more sense.When the next release happens, this will need a package bump on
osu-beatmap-difficulty-lookup-cachein order to stop serving these properties in API responses.Related: ppy/osu-web#11990