Fix osu!taiko mobile scaling not being accurate #32341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
force-pushed
the
taiko-scaling-fixes
branch
from
aa25cd8 to
7f4f92d
Compare
peppy
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should mathematically bring osu!taiko scaling back to match previous releases. There isn't supposed to be manual handling for mobile in osu!taiko scaling logic since the container enforces the playfield to be agnostic to UI scaling (by doing
Scaling = new Vector2(height / 768f)).The actual reason why a difference occurred since the mobile scaling PR is because of the usage of the
maxfunction in the scale computation. When the aspect ratio in phones has been essentially adjusted from1024/768to1024/474, the taiko playfield is supposed to accommodate that by downscaling itself by474/768in here (Parent!.ChildSize.Y = 474). But due to the presence of the max function, no downscaling occurs, and the extra logic added in #31968 is mathematically inaccurate (this explains why a magic constant was necessary).TL;DR: osu!taiko should be fixed now, sorry for the long wait.