Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix osu!taiko and osu!catch being oversized on mobile platforms #31968

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Feb 20, 2025

Attached are screenshots taken on iPhone and iPad after applying the changes in this PR. The changes applied to taiko and catch playfield containers are mostly temporary and will be replaced with appropriate handling for mobile at a later point.

iPad:

IMG_0474
IMG_0473
IMG_0472
IMG_0471

iPhone:

IMG_2003
IMG_2007
IMG_2006
IMG_2004

@frenzibyte frenzibyte added ruleset/osu!taiko ruleset/osu!catch platform/mobile next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Feb 20, 2025
@peppy peppy self-requested a review February 20, 2025 15:16
peppy
peppy previously approved these changes Feb 20, 2025
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not hugely keen on the code but let's give this a try.

@peppy peppy changed the title Fix osu!taiko and osu!catch being unplayable on mobile platforms Fix osu!taiko and osu!catch being oversized on mobile platforms Feb 20, 2025
@peppy peppy force-pushed the fix-scaling-issues branch from b17110f to b111262 Compare February 20, 2025 16:21
@peppy peppy merged commit 1350256 into ppy:master Feb 20, 2025
8 of 10 checks passed
@frenzibyte frenzibyte deleted the fix-scaling-issues branch February 20, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! platform/mobile ruleset/osu!catch ruleset/osu!taiko size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taiko touch buttons are too big on mobile
2 participants