Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread safety when kicking multiplayer users #32214

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Fix thread safety when kicking multiplayer users #32214

merged 2 commits into from
Mar 4, 2025

Conversation

smoogipoo
Copy link
Contributor

Fixes #32129

Not much thought has gone into the null checks, but I've tested a few situations:

  • Being kicked while in the room.
  • Being kicked while in gameplay and returning to room (returns to lounge).

@smoogipoo smoogipoo mentioned this pull request Mar 4, 2025
Closed
@bdach bdach self-requested a review March 4, 2025 08:10
bdach
bdach approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@bdach bdach merged commit 28be0e3 into ppy:master Mar 4, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:multiplayer size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kicking users from room has broken thread safety
3 participants
@smoogipoo @bdach @peppy