Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kicking users from room has broken thread safety #32129

Closed
bdach opened this issue Feb 27, 2025 · 0 comments · Fixed by #32214
Closed

Kicking users from room has broken thread safety #32129

bdach opened this issue Feb 27, 2025 · 0 comments · Fixed by #32214

Comments

@bdach
Copy link
Collaborator

bdach commented Feb 27, 2025

Noticed that this didn't work while testing #31637, but then checked master and ended up discovering that it is unrelated.

Can be reproduced on staging:

  1. Get two multiplayer users in one room
  2. As host, try to kick the other user
  3. Nothing happens
  4. If you try point (2) again, server-side exceptions will fire

On the kicked client this is tripping thread safety assertions that only fire in debug:

Image

cc @smoogipoo - this has nothing to do with your changes, but I am under the impression that you want full control over multiplayer happenings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants