Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple notifications websocket handling from chat operations #26724

Merged
merged 4 commits into from
Jan 29, 2024
+366 −223
Merged

Decouple notifications websocket handling from chat operations #26724

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de52f0a
Decouple notifications websocket handling from chat operations
bdach Jan 25, 2024
c463aa5
xmldoc everything
bdach Jan 25, 2024
243c2bc
Make sure the polling connector actually auto-starts itself
bdach Jan 26, 2024
ef94eff
Rename `PollingChatClientConnector` to better describe usage
peppy Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename PollingChatClientConnector to better describe usage
@peppy
peppy committed Jan 29, 2024

Verified

This commit was signed with the committer’s verified signature.
peppy Dean Herbert
SSH Key Fingerprint: JpqoMLwRkRQ8dD332SMMgI6dQJotIiCBtDwT/3XF9mA
Verified
Learn about vigilant mode
commit ef94eff5745e577cec54615d6c69522100b20b87
2 changes: 1 addition & 1 deletion osu.Game/Online/API/DummyAPIAccess.cs
View file
Original file line number Diff line number Diff line change
@@ -148,7 +148,7 @@ public void UpdateStatistics(UserStatistics newStatistics)

public IHubClientConnector? GetHubConnector(string clientName, string endpoint, bool preferMessagePack) => null;

public IChatClient GetChatClient() => new PollingChatClientConnector(this);
public IChatClient GetChatClient() => new TestChatClientConnector(this);

public RegistrationRequest.RegistrationRequestErrors? CreateAccount(string email, string username, string password)
{
4 changes: 2 additions & 2 deletions osu.Game/Tests/PollingChatClientConnector.cs → osu.Game/Tests/TestChatClientConnector.cs
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@

namespace osu.Game.Tests
{
public class PollingChatClientConnector : PersistentEndpointClientConnector, IChatClient
public class TestChatClientConnector : PersistentEndpointClientConnector, IChatClient
{
public event Action<Channel>? ChannelJoined;

@@ -29,7 +29,7 @@ public void RequestPresence()
// don't really need to do anything special if we poll every second anyway.
}

public PollingChatClientConnector(IAPIProvider api)
public TestChatClientConnector(IAPIProvider api)
: base(api)
{
Start();