Decouple notifications websocket handling from chat operations #26724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a prerequisite for ppy#25480. The `WebSocketNotificationsClient` was tightly coupled to chat specifics making it difficult to use in the second factor verification flow. This commit's goal is to separate the websocket connection and message handling concerns from specific chat logic concerns.
1 task
peppy
approved these changes
Jan 29, 2024
| while (!cancellationToken.IsCancellationRequested) | ||
| { | ||
| await api.PerformAsync(CreateInitialFetchRequest()).ConfigureAwait(true); | ||
| await Task.Delay(1000, cancellationToken).ConfigureAwait(true); |
There was a problem hiding this comment.
I get bad memories of call stacks getting infinitely longer with Task.Delay in a loop, but we've used it elsewhere since so maybe it's been fixed.
There was a problem hiding this comment.
Isn't new code either, was just moved from old place of usage, so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for #25480.
The
WebSocketNotificationsClientwas tightly coupled to chat specifics making it difficult to use in the second factor verification flow. This PR's goal is to separate the websocket connection and message handling concerns from specific chat logic concerns.I apologise for the diff in advance, but extricating this out in a sane manner was difficult enough to begin with and I'm still not entirely happy with where things at. I had major trouble trying to decipher the reasoning behind the
PersistentEndpointClient/PersistentEndpointClientConnectordichotomy, and I can't get rid of it without uprooting more stuff (and I do want to be using those becausePersistentEndpointClientConnectorhas the nice retry logic that I would like the notification websocket to be using).