Add ability to step forward/backwards single frames when watching replays #26607
Conversation
|
I'd like for there to be a shortcut to move frame by frame (since you can basically already move and pause without using the panel), it would make analysing replays easier. |
peppy
force-pushed
the
replay-seek-single-frame
branch
from
e1b58f1 to
8c4af58
Compare
I've added these, required a bit of refactoring. |
| case GlobalAction.SeekReplayBackward: | ||
| keyboardSeek(-1); | ||
| SeekInDirection(-1); |
There was a problem hiding this comment.
Is there any particular reason why this seeks in second increments rather than 5-second increments like previously?
There was a problem hiding this comment.
Yeah I felt like it made more sense to match the keyboard key for seeking. The difference between the two buttons previously was almost nothing, especially with the click-repeat being present (it gets fast very fast).
| }, | ||
| new SeekButton | ||
| { | ||
| Anchor = Anchor.Centre, | ||
| Origin = Anchor.Centre, | ||
| Icon = FontAwesome.Solid.Backward, | ||
| Action = () => seek(-1, seek_amount), | ||
| TooltipText = PlayerSettingsOverlayStrings.SeekBackwardSeconds(seek_amount / 1000), | ||
| Action = () => replayPlayer.SeekInDirection(-1), |
There was a problem hiding this comment.
Same thing here, this used to be 5sec but is now 1sec.
replay-controls.mp4 |
I also did a bit of tidy-up on the
PlaybackSettingsclasses, mostly stuff I missed in the initial review.Please ignore the state of the pause/play button being wrong. It is unrelated and looks to be a framework side issue (ppy/osu-framework#6139).
CleanShot.2024-01-18.at.06.02.36.mp4