Allow seeking while paused #26606
Merged
Allow seeking while paused #26606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Fix `ConstrainedIconContainer` always using masking without a reason
We are already manually calling `base.UpdateSubTree` when we need to. Changing this flag is doing nothing and just adds to the complexity of the implementation.
…ing replay playback
peppy
force-pushed
the
frame-stable-update-while-paused
branch
from
c7abc21 to
e739105
Compare
bdach
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intention is to eventually allow the game update loop to continue while paused, even during local gameplay. The reasoning for this is to allow things like skin changing to reflect immediately.
This is a first step in that direction, which will allow is to gauge if anything is going to go wrong as a result in a safer mode of operation (replay, doesn't affect local user's plays etc.). The huge benefit of this is that seeking while paused will now work correctly.
The original limitation was added in #4534 to "fix cursor positioning". If that's the only thing that needs fixing then it can easily be fixed.