Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SettingsToolboxGroup allocating excessively due to missing cache validation #26456

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix SettingsToolboxGroup allocating excessively due to missing cache validation #26456

merged 1 commit into from
Jan 9, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 9, 2024 •
edited
Loading

CleanShot 2024-01-09 at 09 34 52

@bdach bdach self-requested a review January 9, 2024 13:26
bdach
bdach approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😶

outstanding review, me-2-years-ago, well done

@bdach bdach merged commit a252235 into ppy:master Jan 9, 2024
@peppy peppy deleted the fix-missing-validation branch January 12, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
size/XS type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @bdach