Contract editor toolboxes when not in use #16342
Conversation
|
The contracted headings don't look super great:
Maybe they should be hidden entirely, or show only the hotkeys in contracted mode (as in, say 1-9 / Q~P respectively), and only show the full text when expanded? |
|
That's what I meant by the weird truncation. I'm not too annoyed by it, but can try hiding if required. |
| @@ -121,15 +115,13 @@ public ExpandedState State | |||
|
|
|||
| private Drawable lastHoveredButton; | |||
|
|
|||
| private Drawable hoveredButton => content.Children.FirstOrDefault(c => c.IsHovered); | |||
| private Drawable hoveredButton => FillFlow.ChildrenOfType<OsuButton>().FirstOrDefault(c => c.IsHovered); | |||
There was a problem hiding this comment.
Not sure on the ChildrenOfType<OsuButton>() usage here. Was generally agreed that it shouldn't be used in non-test contexts.
I'm not even too sure it needs to exist - you could generalise this to any child drawable - and even if it does need to exist, I'd prefer that it didn't perform recursive lookups.
There was a problem hiding this comment.
Unfortunately for the editor case, the buttons are quite deep inside the usage. Not sure there's a better way to do this.
There was a problem hiding this comment.
I suppose so. I guess I could look away and treat this as an exception (like the skin editor, which also uses ChildrenOfType<>() upon double checking).
There was a problem hiding this comment.
I've reduced the invocations of this anyway, and added an inline comment explaining why it's there.
Follow up to #16327. Reusing existing UX which seems like a good idea until we have something better. Truncation is a bit weird but I think it's fine for now.
20220106.211113.osu.Game.Tests.mp4